Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 82 and 83: Use term generics and add generic defaults with stop message #91

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jun 7, 2024

Description

This PR closes #82 and #83.

I've changed:

  • file name from methods.R to generics.R
  • separate file for defaults.R and separate family tag
  • add defaults for almost all generics with error message about not having a method for that class

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The issue with prepare stems from us abusing the default method as a class constructor.

@seabbs seabbs enabled auto-merge June 7, 2024 09:55
@seabbs seabbs added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit d1db813 Jun 7, 2024
1 of 8 checks passed
@seabbs seabbs deleted the rename-methods-to-generics branch June 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default method for more generics giving warning about no implementation for this class
2 participants