Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkgdown enwtheme not being used #452

Closed
seabbs opened this issue Apr 12, 2024 · 8 comments
Closed

Pkgdown enwtheme not being used #452

seabbs opened this issue Apr 12, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@seabbs
Copy link
Collaborator

seabbs commented Apr 12, 2024

As the title currently the custom epinowcast/enwtheme is not being used. Looking at the output of pkgdown this failure is silent.

There has been a recent pkgdown update which may have led to this behaviour. @Bisaloo pinging in case you know what this is?

@seabbs seabbs added the bug Something isn't working label Apr 12, 2024
@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 12, 2024

It is used as far as I can tell. What makes you say it's not used?

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 12, 2024

When it was building the dev docs it used the right theme (i.e the one being specified in the enwtheme) and now it's using the default theme? Your right in the sense the sidebar changes are showing up etc.

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 12, 2024

I.e package.epinowcast.org Vs package.epinowcast.org/dev

@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 12, 2024

We have issues with the pkgdown update in other packages as well. This seems to be the fix: https://github.com/epiverse-trace/epiCo/pull/119/files.

I can't test it locally right now so feel free to give it a go or I will try again later next week.

@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 15, 2024

This will be fixed by r-lib/pkgdown#2441 as soon as it hits main since we're installing pkgdown from its GitHub repo.

@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 16, 2024

This is now fixed: https://package.epinowcast.org

@pearsonca
Copy link
Collaborator

pearsonca commented Apr 16, 2024 via email

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 16, 2024

Ah awesome - thanks @Bisaloo I thought you might be across this and good shout @pearsonca

@seabbs seabbs closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants