Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force numeric for prediction and true value when scoring #201

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 2, 2023

This PR closes #198 by forcing the conversion of true_value and prediction as indicated by @nikosbosse (the author of scoringutils) as the likely fix.

It also increments the dev version and adds a news item (the review might consider adding a reviewed by tag to this once their review is complete).

The following code now works as expected and package tests are passing.

library(epinowcast)
 
     nowcast <- enw_example("nowcast")
     summarised_nowcast <- summary(nowcast)
     obs <- enw_example("observations")
 
    enw_score_nowcast(summarised_nowcast, obs)

@seabbs seabbs added the bug Something isn't working label Mar 2, 2023
@seabbs seabbs self-assigned this Mar 2, 2023
NEWS.md Outdated Show resolved Hide resolved
R/model-validation.R Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #201 (599f80b) into develop (edb2254) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 599f80b differs from pull request most recent head e400f8a. Consider uploading reports for the commit e400f8a to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
+ Coverage    88.18%   88.20%   +0.01%     
===========================================
  Files           14       14              
  Lines         1490     1492       +2     
===========================================
+ Hits          1314     1316       +2     
  Misses         176      176              
Impacted Files Coverage Δ
R/model-validation.R 95.45% <100.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seabbs seabbs requested a review from pearsonca March 2, 2023 14:09
Copy link
Collaborator Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review) building on @pearsonca review whose suggestions were adopted without any additional changes.

@seabbs seabbs merged commit 2b06668 into develop Mar 2, 2023
@seabbs seabbs deleted the seabbs/issue198 branch March 2, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants