-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples and tests for epinowcast
methods and uncovered plots
#209
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #209 +/- ##
===========================================
+ Coverage 88.20% 94.10% +5.89%
===========================================
Files 14 14
Lines 1492 1492
===========================================
+ Hits 1316 1404 +88
+ Misses 176 88 -88
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems generally fine, but also: this should be its own extension package.
@pearsonca do you have a review decision on this? Going to merge in #208 first, resolve merge issues, and then merge this in once ready. |
Comfortable with it. Added issue(+) for splitting off vis package + introspecting Qs. |
This PR adds basic examples and tests for
summary.epinowcast()
,plot.epinowcast()
, andenw_plot_obs()
(which was the only plotting function not fully covered by the new tests forplot.epinowcast()
).It also resolves an issue with the default in
enw_plot_quantiles
which wasTRUE
vsFALSE
as documented.