Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples and tests for epinowcast methods and uncovered plots #209

Merged
merged 6 commits into from
Mar 26, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 26, 2023

This PR adds basic examples and tests for summary.epinowcast(), plot.epinowcast(), and enw_plot_obs() (which was the only plotting function not fully covered by the new tests for plot.epinowcast()).

It also resolves an issue with the default in enw_plot_quantiles which was TRUE vs FALSE as documented.

@seabbs seabbs added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 26, 2023
@seabbs seabbs linked an issue Mar 26, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #209 (f6cebff) into develop (2b06668) will increase coverage by 5.89%.
The diff coverage is n/a.

❗ Current head f6cebff differs from pull request most recent head 2dc3b7b. Consider uploading reports for the commit 2dc3b7b to get more accurate results

@@             Coverage Diff             @@
##           develop     #209      +/-   ##
===========================================
+ Coverage    88.20%   94.10%   +5.89%     
===========================================
  Files           14       14              
  Lines         1492     1492              
===========================================
+ Hits          1316     1404      +88     
+ Misses         176       88      -88     
Impacted Files Coverage Δ
R/methods.R 100.00% <ø> (+46.66%) ⬆️
R/plot.R 91.66% <ø> (+91.66%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@pearsonca pearsonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems generally fine, but also: this should be its own extension package.

R/methods.R Show resolved Hide resolved
R/plot.R Show resolved Hide resolved
@seabbs
Copy link
Collaborator Author

seabbs commented Mar 26, 2023

@pearsonca do you have a review decision on this? Going to merge in #208 first, resolve merge issues, and then merge this in once ready.

@pearsonca
Copy link
Collaborator

Comfortable with it. Added issue(+) for splitting off vis package + introspecting Qs.

@seabbs seabbs merged commit 1881043 into develop Mar 26, 2023
7 checks passed
@seabbs seabbs deleted the test-plots branch March 26, 2023 15:40
@seabbs seabbs mentioned this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests of visualisation
2 participants