Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depreciate enw_dates_to_factors #216

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Depreciate enw_dates_to_factors #216

merged 3 commits into from
Mar 29, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 29, 2023 •
edited

This PR removes enw_dates_to_factors as discussed in #206.

@seabbs seabbs added enhancement New feature or request low-priority labels Mar 29, 2023
@seabbs seabbs linked an issue Mar 29, 2023 that may be closed by this pull request
Depreciate enw_dates_to_factors #206
Closed
@adrian-lison
Fix typo
e10c276 
I think it is called "deprecated"...
adrian-lison
adrian-lison approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@adrian-lison adrian-lison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go!! I only changed "depreciated" to "deprecated"

@seabbs seabbs merged commit 74c4ac3 into develop Mar 29, 2023
1 of 7 checks passed
@seabbs seabbs deleted the seabbs/issue206 branch March 29, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-lison adrian-lison adrian-lison approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request low-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depreciate enw_dates_to_factors
2 participants
@seabbs @adrian-lison