Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for check_ functions and remove internal plots #217

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Mar 30, 2023

This PR increases test coverage by adding unit tests for check_ functions where missing. In adding these tests I noticed that check_quantiles was not as flexible as originally intended so I have refactored.

I have also removed two internal plot functions that were not be used and were untested.

@seabbs seabbs added the enhancement New feature or request label Mar 30, 2023
@seabbs seabbs self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #217 (5bdcfc1) into develop (93d3575) will increase coverage by 1.11%.
The diff coverage is 100.00%.

❗ Current head 5bdcfc1 differs from pull request most recent head ad75296. Consider uploading reports for the commit ad75296 to get more accurate results

@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
+ Coverage    96.18%   97.29%   +1.11%     
===========================================
  Files           14       14              
  Lines         1521     1517       -4     
===========================================
+ Hits          1463     1476      +13     
+ Misses          58       41      -17     
Impacted Files Coverage Δ
R/plot.R 100.00% <ø> (+8.33%) ⬆️
R/check.R 100.00% <100.00%> (+20.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seabbs seabbs requested a review from Bisaloo March 31, 2023 13:47
Copy link
Collaborator

@adrian-lison adrian-lison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as expected.

I added a separate error message for invalid probabilities in case we (indirectly) expose this more to users at a later point.

@seabbs seabbs merged commit f0b58ee into develop Mar 31, 2023
7 checks passed
@seabbs seabbs deleted the test-gaps branch March 31, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants