Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline and tighten lintr checks #220

Merged
merged 23 commits into from Apr 11, 2023
Merged

Streamline and tighten lintr checks #220

merged 23 commits into from Apr 11, 2023

Commits on Apr 5, 2023

  1. Replace lint.yaml by lint-changed-file.yaml 

    Copied from r-lib/actions with some extra bells and whistles copied from lint.yaml

- triggered on develop and can be triggered manually
- can be skipped with the [ci skip] instruction in the commit message
    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    5e9d1fc View commit details
    Browse the repository at this point in the history

  2. Try to include all linters

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0f5e72b View commit details
    Browse the repository at this point in the history

  3. Fix some indents 

    Indents in function argument definition have not been changed because they are an explicit style choice
    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bfa4418 View commit details
    Browse the repository at this point in the history

  4. Add fixed = TRUE to calls with fixed regexes

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4ea8fb3 View commit details
    Browse the repository at this point in the history

  5. Add leading zero to double

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3a6324f View commit details
    Browse the repository at this point in the history

  6. Use toString() rather than paste(collapse = ", ")

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    53036b7 View commit details
    Browse the repository at this point in the history

  7. Use anyNA() rather than any(is.na())

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7ce6a9e View commit details
    Browse the repository at this point in the history

  8. Remove unused variables

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9d4a36a View commit details
    Browse the repository at this point in the history

  9. Pass function directly to sapply instead of creating lambda

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ebd46cc View commit details
    Browse the repository at this point in the history

  10. Use dedicated lengths() function

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9087f81 View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary library() calls

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    93b7be2 View commit details
    Browse the repository at this point in the history

  12. Use file.path() to construct file paths

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    01be4eb View commit details
    Browse the repository at this point in the history

  13. Replace unnecessary ifelse() by as.numeric()

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    4789ca8 View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary paste0() in warning() and stop()

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e4364a2 View commit details
    Browse the repository at this point in the history

  15. Remove unnecessary c()

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2d77237 View commit details
    Browse the repository at this point in the history

  16. Use seq_len() rather than :

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    705774f View commit details
    Browse the repository at this point in the history

  17. Use sort() rather than order()

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    276dd57 View commit details
    Browse the repository at this point in the history

  18. Remove nested if

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    ff6a8cf View commit details
    Browse the repository at this point in the history

  19. Disable linters that generate too many false positive 

    or that flag explicit style choices that diverge from default
    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    cb2e939 View commit details
    Browse the repository at this point in the history

  20. Run devtools::document()

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    257d13e View commit details
    Browse the repository at this point in the history

  21. Add NEWS items

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e85d996 View commit details
    Browse the repository at this point in the history

  22. Increment version number

    @Bisaloo
    Bisaloo committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f99c193 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Remove extra trailing whitespace

    @Bisaloo
    Bisaloo committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d704ce3 View commit details
    Browse the repository at this point in the history