Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @bisaloo as an author and @pratikunterwegs as a contributor #225

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Apr 7, 2023

This PR adds @Bisaloo as a package author and @pratikunterwegs as a contributor and reorders the DESCRIPTION to go authors and then contributors. I may have missed people who should be credited here so please make suggestions.

@Bisaloo and @pratikunterwegs if you could both confirm you are fine to be added here that would be great.

@seabbs seabbs requested a review from adrian-lison April 7, 2023 10:26
@seabbs seabbs changed the title Add @bisaloo as an author Add @bisaloo as an author and @pratikunterwegs as a contributor Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #225 (d56e6b7) into develop (4c760f6) will not change coverage.
The diff coverage is n/a.

❗ Current head d56e6b7 differs from pull request most recent head c836b2c. Consider uploading reports for the commit c836b2c to get more accurate results

@@           Coverage Diff            @@
##           develop     #225   +/-   ##
========================================
  Coverage    97.30%   97.30%           
========================================
  Files           14       14           
  Lines         1524     1524           
========================================
  Hits          1483     1483           
  Misses          41       41           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seabbs seabbs requested review from pearsonca and Bisaloo April 7, 2023 16:08
Copy link
Collaborator

@pearsonca pearsonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one consistency note, but technically fine

DESCRIPTION Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
Co-authored-by: Hugo Gruson <Bisaloo@users.noreply.github.com>
@seabbs seabbs merged commit 177cc32 into develop Apr 11, 2023
8 checks passed
@seabbs seabbs deleted the add-bisaloo-as-aut branch April 11, 2023 14:05
Copy link
Collaborator

@adrian-lison adrian-lison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have new contributors/authors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants