Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enw_metadata() target_date default be detected from the function specification #232

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Apr 14, 2023

This PR closes #212 by detecting the defaults for target_date from the function specification using formals().

@seabbs seabbs added enhancement New feature or request reviewer-needed labels Apr 14, 2023
@seabbs seabbs self-assigned this Apr 14, 2023
@seabbs seabbs linked an issue Apr 14, 2023 that may be closed by this pull request
@seabbs seabbs requested a review from pearsonca April 14, 2023 09:59
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #232 (ec87e5a) into develop (c5029b6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ec87e5a differs from pull request most recent head 760aeea. Consider uploading reports for the commit 760aeea to get more accurate results

@@           Coverage Diff            @@
##           develop     #232   +/-   ##
========================================
  Coverage    97.31%   97.31%           
========================================
  Files           14       14           
  Lines         1527     1527           
========================================
  Hits          1486     1486           
  Misses          41       41           
Impacted Files Coverage Δ
R/preprocess.R 96.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 17, 2023

I've self-reviewed this and planning to merge without further review as this is a relatively simple change.

@seabbs seabbs merged commit d21ab56 into develop Apr 17, 2023
7 checks passed
@seabbs seabbs deleted the seabbs/issue212 branch April 17, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRY out manual specification of some match.arg'd items
1 participant