Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates citation file with new authors #236

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Updates citation file with new authors #236

merged 3 commits into from
Apr 17, 2023

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Apr 17, 2023

This PR closes #230 by updating the CITATION file with the new package authors and rerendering the README.

@seabbs seabbs added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 17, 2023
@seabbs seabbs linked an issue Apr 17, 2023 that may be closed by this pull request
Copy link
Collaborator Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT (self-review).

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #236 (ed4adff) into develop (d21ab56) will decrease coverage by 0.05%.
The diff coverage is 97.43%.

❗ Current head ed4adff differs from pull request most recent head f8d7c4f. Consider uploading reports for the commit f8d7c4f to get more accurate results

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
- Coverage    97.31%   97.27%   -0.05%     
===========================================
  Files           14       14              
  Lines         1527     1540      +13     
===========================================
+ Hits          1486     1498      +12     
- Misses          41       42       +1     
Impacted Files Coverage Δ
R/formula-tools.R 95.00% <96.15%> (-0.24%) ⬇️
R/check.R 100.00% <100.00%> (ø)
R/model-design-tools.R 100.00% <100.00%> (ø)
R/model-tools.R 99.20% <100.00%> (ø)
R/plot.R 100.00% <100.00%> (ø)
R/preprocess.R 96.44% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seabbs seabbs merged commit 94da17a into develop Apr 17, 2023
7 checks passed
@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 17, 2023

I can open another issue for this but it looks like the recommended syntax now uses bibentry() rather than citEntry()

PS: I'm too slow 🙈

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 17, 2023

😆 sorry that is my bad. I just assumed I couldn't muck this up!

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 17, 2023

Clearly I could. Will update in another PR (woop woop)

@seabbs
Copy link
Collaborator Author

seabbs commented Apr 17, 2023

Okay. Do you have an example of this? I am not finding one!

@seabbs seabbs deleted the seabbs/issue230 branch April 17, 2023 14:20
@Bisaloo
Copy link
Collaborator

Bisaloo commented Apr 17, 2023

r-lib/usethis#1695

This was referenced Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update citation
2 participants