Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#387 draft use of make-based approach #456

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

pearsonca
Copy link
Collaborator

Description

This PR demonstrates the idea discussed in #387. Briefly, the idea is intro make rules for building some of the package content (e.g. vignettes), with the idea of simplifying local and automated builds of these package elements.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@pearsonca pearsonca added enhancement New feature or request infrastructure labels Apr 30, 2024
@pearsonca
Copy link
Collaborator Author

Some open items maybe to do:

  • updating actions to take advantage of the infrastructure addition
  • dissecting the vignette builds a bit more to focus the rebuilding a bit (e.g. separate out the computation a bit)

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this makes sense though ideally would be able to selective build certain vignettes. Can we override the checkpointing to force an update (this might be needed when R code changes but the vignettes themselves remain the same)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants