Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model description clarifications #71

Merged
merged 10 commits into from
Jul 7, 2022
Merged

Conversation

sbfnk
Copy link
Collaborator

@sbfnk sbfnk commented Jun 29, 2022

Some small corrections and a few suggested clarifications to the model description.

@seabbs seabbs self-requested a review June 29, 2022 09:06
@seabbs seabbs changed the base branch from main to develop June 29, 2022 09:06
@epinowcast epinowcast deleted a comment from codecov bot Jun 29, 2022
@seabbs
Copy link
Collaborator

seabbs commented Jun 29, 2022

Thanks, will review it today. Just noting the last 2 bullets in the contributing guide (https://epiforecasts.io/epinowcast/CONTRIBUTING.html) and ideally these changes should be targeted at the develop branch (which is not in the contributing guide but will be soon)

@sbfnk
Copy link
Collaborator Author

sbfnk commented Jun 29, 2022

updated to address #78 and for consistent notation with regard to times and dates (related to #81).

@seabbs seabbs mentioned this pull request Jul 4, 2022
21 tasks
@epinowcast epinowcast deleted a comment from codecov bot Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #71 (d47dcbf) into develop (ba6f217) will not change coverage.
The diff coverage is n/a.

❗ Current head d47dcbf differs from pull request most recent head 005b74f. Consider uploading reports for the commit 005b74f to get more accurate results

@@           Coverage Diff            @@
##           develop      #71   +/-   ##
========================================
  Coverage    62.57%   62.57%           
========================================
  Files           12       12           
  Lines          946      946           
========================================
  Hits           592      592           
  Misses         354      354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6f217...005b74f. Read the comment docs.

@seabbs seabbs linked an issue Jul 7, 2022 that may be closed by this pull request
@seabbs seabbs closed this Jul 7, 2022
@seabbs seabbs reopened this Jul 7, 2022
@seabbs seabbs merged commit 3dc4ac0 into develop Jul 7, 2022
@seabbs seabbs deleted the model-description-sbfnk-review branch July 7, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that reference/occurrence date are the same thing
2 participants