Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update few files #92

Merged
merged 4 commits into from May 6, 2024
Merged

Update few files #92

merged 4 commits into from May 6, 2024

Conversation

Karim-Mane
Copy link
Member

@Karim-Mane Karim-Mane commented Apr 3, 2024

In this PR, I have fixed few typos and raised few questions/suggestions:

  1. In the section Software development as co-creation, consider adding a link to resources that explain how to acknowledge contributions from collaborators on the following point:
  • User contributions need to be valued and acknowledged clearly. See here for more details.
  1. On the same section, might be worth considering a broader view of pair-programming:
  • Co-creation can also take the form of pair-programming to combine domain experts and developers
    I think pair-programming also includes the combination of 2 developers to code as they brainstorm.
  1. On the Documentation section:
  • Provide user-friendly cheatsheets in html and pdf: is it possible to provide a list of these cheatsheets?

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for playful-gelato-7892ba ready!

Name Link
🔨 Latest commit 4301877
🔍 Latest deploy log https://app.netlify.com/sites/playful-gelato-7892ba/deploys/660e89abcfb41e00084efa7a
😎 Deploy Preview https://deploy-preview-92--playful-gelato-7892ba.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have asked to revert a couple of changes because I believe they were correct.

Regarding your questions:

  1. Could you submit a PR to add a link to the contributions chapter in
    ::: {.callout-tip title="Read more about this principle in application"}
    - [What should the first 100 lines of code written during an epidemic look like?](https://epiverse-trace.github.io/posts/100days-workshop/)
    - [Communicating development stages of open-source software](https://epiverse-trace.github.io/posts/comm-software-devel/)
    :::
    ?
  2. I believe what we meant is that co-creation with domain experts can be done via pair programming. Please suggest a better phrasing if it's unclear
  3. We don't have cheatsheets at the moment as far as I know but here are examples outside of Epiverse: https://rstudio.github.io/cheatsheets/contributed-cheatsheets.html

principles.qmd Outdated Show resolved Hide resolved
principles.qmd Outdated Show resolved Hide resolved
principles.qmd Outdated Show resolved Hide resolved
Karim-Mane and others added 3 commits April 4, 2024 11:05
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
@Karim-Mane
Copy link
Member Author

Thanks for the PR. I have asked to revert a couple of changes because I believe they were correct.

Regarding your questions:

1. Could you submit a PR to add a link to the contributions chapter in https://github.com/epiverse-trace/blueprints/blob/bf64c4f0367bc25575ccb878bcf01342d3a9e4aa/principles.qmd#L35-L40
   ?

can't it be done on this PR? given that I have reverted some changes to what was there before as you suggested.

2. I believe what we meant is that co-creation with domain experts can be done via pair programming. Please suggest a better phrasing if it's unclear

I agree with co-creation with domain experts can be done via pair programming as it's simpler to my opinion.

3. We don't have cheatsheets at the moment as far as I know but here are examples outside of Epiverse: https://rstudio.github.io/cheatsheets/contributed-cheatsheets.html

thanks for sharing this. Maybe consider adding this as an example:

  • Provide user-friendly cheatsheets in html and pdf (example cheatsheets can be found here)

@Bisaloo
Copy link
Member

Bisaloo commented Apr 4, 2024

Yes, please feel free to add these 3 changes in this PR.

@chartgerink
Copy link
Member

If you would like to add any further changes please provide a new PR. I will now merge this as it's been open for over a month without updates, plus the included changes are very minor.

I approved the PR to document my approval of the current state.

@chartgerink chartgerink merged commit b6b61c2 into main May 6, 2024
5 checks passed
@chartgerink chartgerink deleted the review_Karim branch May 6, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants