Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system dependency instruction #124

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add system dependency instruction #124

merged 4 commits into from
Feb 14, 2024

Conversation

chartgerink
Copy link
Member

I added a small piece to the README to indicate that there is a need to install a system dependency upon the first run of the template.

This is not required for installing the package - just for generating the template report.

Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's helpful! This may also need to be documented in the report itself.

Could you also please open an issue highlighting that we should remove the epitrix package dependency (which pulls this system dependency) when possible?

(PS: I watch this repo and jumped the gun when I saw the notification, thinking I was assigned as a reviewer. Very happy to hear Carmen's perspective as the closest person to this package at the moment.)

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb004c9) 70.83% compared to head (bed0ee8) 73.07%.
Report is 8 commits behind head on main.

❗ Current head bed0ee8 differs from pull request most recent head 80c31d8. Consider uploading reports for the commit 80c31d8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   70.83%   73.07%   +2.24%     
==========================================
  Files           4        4              
  Lines          24       26       +2     
==========================================
+ Hits           17       19       +2     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chartgerink
Copy link
Member Author

Reinviting reviews as this has been open for a while - opened the issue and updated the report as well. 👍

Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
@chartgerink chartgerink merged commit 0b7406f into main Feb 14, 2024
9 checks passed
@chartgerink chartgerink deleted the add/sys-deps branch February 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants