-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system dependency instruction #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's helpful! This may also need to be documented in the report itself.
Could you also please open an issue highlighting that we should remove the epitrix package dependency (which pulls this system dependency) when possible?
(PS: I watch this repo and jumped the gun when I saw the notification, thinking I was assigned as a reviewer. Very happy to hear Carmen's perspective as the closest person to this package at the moment.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 70.83% 73.07% +2.24%
==========================================
Files 4 4
Lines 24 26 +2
==========================================
+ Hits 17 19 +2
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Reinviting reviews as this has been open for a while - opened the issue and updated the report as well. 👍 |
inst/rmarkdown/templates/transmissibility/skeleton/skeleton.Rmd
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo Gruson <10783929+Bisaloo@users.noreply.github.com>
I added a small piece to the README to indicate that there is a need to install a system dependency upon the first run of the template.
This is not required for installing the package - just for generating the template report.