Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theoretical background #193

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Theoretical background #193

merged 9 commits into from
Apr 8, 2024

Conversation

adamkucharski
Copy link
Member

@adamkucharski adamkucharski commented Feb 7, 2024

  • Please check if the PR fulfills these requirements
  • [X ] I have read the CONTRIBUTING guidelines
  • [ X] A new item has been added to NEWS.md. This is just a vignette, but can add if required.
  • [X ] Tests for the changes have been added (for bug fixes / features). This is just a vignette.
  • [X ] Docs have been added / updated (for bug fixes / features). This is adding a vignette.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Add vignette on theoretical background. This is currently a draft to allow input from @BlackEdder before converting to full PR.

@adamkucharski adamkucharski marked this pull request as ready for review February 13, 2024 21:48
@pratikunterwegs
Copy link
Collaborator

Just nudging @BlackEdder to take a look at this final size theory PR, thanks!

@adamkucharski
Copy link
Member Author

For context @BlackEdder, this is basically just be a formal PR for the edits you've already reviewed.

@BlackEdder
Copy link

Thanks, I'll take a quick look tomorrow morning

@pratikunterwegs pratikunterwegs merged commit 405607f into main Apr 8, 2024
@pratikunterwegs pratikunterwegs deleted the theoretical-background branch April 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants