Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web player: Replaygain support #38

Closed
abdulocracy opened this issue Mar 20, 2020 · 11 comments
Closed

Web player: Replaygain support #38

abdulocracy opened this issue Mar 20, 2020 · 11 comments
Milestone

Comments

@abdulocracy
Copy link

Replaygain support would be great to have in the LMS web player, I believe the Subsonic web interface does this.

@epoupon epoupon changed the title Replaygain support Web player: Replaygain support Mar 20, 2020
@epoupon
Copy link
Owner

epoupon commented Mar 20, 2020

Hey! I think it may be done with a reasonable amount of work.

@epoupon epoupon added this to the v3.12.0 milestone Apr 18, 2020
@epoupon
Copy link
Owner

epoupon commented Apr 22, 2020

Ok I have started to think seriously about this.
For #46, I have made the audio settings local to each browser, since several browsers usually mean several different ways of listening to music (home, mobile, work for instance).

I am wondering about settings for this one. Actually there are quite a lot of parameters to make it interesting:
image
I think it would make sense to make parameters local to the browser too.

What do you think?

@abdulocracy
Copy link
Author

The usual settings for RG are a toggle for album or track normalization, pre-amp and an option to apply compression to prevent clipping. Here's another example from Strawberry:
Screenshot from 2020-04-22 17-48-26

As for making the settings local, it makes sense, as this is more a web client feature, RG adjustment over the Subsonic API isn't required, as the RG tags are already sent, and the client (e.g. Strawberry, DSub) handles the adjustment.

@epoupon
Copy link
Owner

epoupon commented Apr 22, 2020

Ok, let's try to keep all web player settings local then :)

@epoupon
Copy link
Owner

epoupon commented Apr 24, 2020

By the way, what soft do you use to set replaygain metadata?
I use mp3gain and I had to hack a bit to find the tags (APE format in a MP3 file that already contains ID3v2 tags...). I would like to have another use example.

@abdulocracy
Copy link
Author

I use beets to calculate and embed RG metadata, which uses various backends, I use the ffmpeg backend.

@epoupon
Copy link
Owner

epoupon commented Apr 24, 2020

Would you mind sending me some sample files with replay gain values in? (flac, wma, mp3 would be much appreciated!)

@abdulocracy
Copy link
Author

I have some FLAC and MP3s, and can transcode some WMAs. I'll send some to your email.

@epoupon
Copy link
Owner

epoupon commented Apr 25, 2020

What would you think about an automatic replay gain mode?
For example, if there is only songs of the same album in the playlist (or maybe if the previous or next song is from the same album => use album gain), otherwise fallback on track gain.

@epoupon
Copy link
Owner

epoupon commented Apr 26, 2020

It feels like we really need a setting to apply preamp on tracks that do not have RG info, I am about to add that too.

Like this in foobar2k:
image

@abdulocracy
Copy link
Author

What would you think about an automatic replay gain mode?
For example, if there is only songs of the same album in the playlist (or maybe if the previous or next song is from the same album => use album gain), otherwise fallback on track gain.

This is a quite common feature in players, I think it would be great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants