Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: enable transcoding only for certain file types #46

Closed
AlphaJack opened this issue Apr 9, 2020 · 3 comments
Closed
Milestone

Comments

@AlphaJack
Copy link

Can you add an option to transcode only certain file types? This would be useful when one has both lossy and lossless files in his library

@epoupon epoupon added this to the v3.12.0 milestone Apr 18, 2020
@epoupon
Copy link
Owner

epoupon commented Apr 19, 2020

Was thinking about this : maybe we would need an automatic mode here?
Something like "transcode only if native format is not supported". However, that would work only for the web player. It would be necessary to make a dedicated transcode settings for it.

@epoupon
Copy link
Owner

epoupon commented Apr 19, 2020

Ok I tested this idea and it seems to work fine. The web player automatically falls back on the transcoded version if it does not manage to use the native file.

Here is what I am planning in order to simply the whole thing:

  1. Reintroduce the configuration-file based option to enable/disable the Subsonic API (what I did in 3.11.0 seems to be a bad move unfortunately) and remove the subsonic API panel from administration menu.
  2. Create a new Subsonic API section in the user's settings panel (only if the API is enabled). In here, put the following option:s
    • preferred transcoding option: none/mp3/ogg/etc. (used if it is not set in the format arg of the stream command)
    • preferred transcoding bitrate (used if it is not set in the format arg)
    • Artist list mode: (all artists/ album artists)
  3. Make the current transcode section local to the browser (i.e. store information in local storage), with the following options: (could be made local storage in a further step though). The idea of this is to get different transcode parameters if you are at home/work/mobile.
    • Transcode mode : auto/never/always (maybe auto needs something more explicit like 'only if not supported')
    • Transcode format: as before
    • Transcode bitrate : as before
  4. As there is now multiple ways to get the files from the server, remove the max bitrate option that exists for each user.

epoupon added a commit that referenced this issue Apr 20, 2020
…not handled by the browser. Made the subsonic API configurable again in conf file. Moved the subsonic's artist list mode in the per-user settings page. fixes #46
@epoupon epoupon closed this as completed Apr 20, 2020
@epoupon
Copy link
Owner

epoupon commented Apr 20, 2020

Feel free to open additional issues if it does not fit your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants