Duplicate code - 'dry run' did nothing

[jesusbagpuss]

Duplicate set of document update+commit/eprint regenerate, both inside and outside the 'if not dry-run' block (effectively meaning that 'dry-run' was also a wet-run...).

[jesusbagpuss]

Probably shouldn't include the 'email someone' stuff in the dry run either...

[sebastfr]

Code on master and 3.3 now ok?

[jesusbagpuss]

I think so - got my commits in a twist and couldn't seem to edit it (so I closed it and opened a new one)...

[sebastfr]

Laaaaame... I only saw the first pull request, which was closed as you
said... Well at least it's all committed now...

Seb.

On 20/01/14 17:09, jesusbagpuss wrote:

I think so - got my commits in a twist and couldn't seem to edit it
(so I closed it and opened a new one)...

—
Reply to this email directly or view it on GitHub
#190 (comment) Bug
from
https://github.com/notifications/beacon/912679__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNTc3MDU5MCwiZGF0YSI6eyJpZCI6MjM4NjcyNDh9fQ==--6edd350b5a3f3f23efdd70d1777a6c0140e7e43b.gif

[jesusbagpuss]

So I'll close this #191 then!

[sebastfr]

On 20/01/14 17:15, jesusbagpuss wrote:

So I'll close this #191 #191
then!

—
Reply to this email directly or view it on GitHub
#190 (comment) Bug
from
https://github.com/notifications/beacon/912679__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNTc3MDk1OCwiZGF0YSI6eyJpZCI6MjM4NjcyNDh9fQ==--2d4b98f6b21cac38499b92cdf3fabf7a2d5becda.gif

Yes and I'll get all the glory for you fix, mwahaha!

[jesusbagpuss]

👊
I'm thinking about making a 'pre-expiry-warning' rather than just a 'your embargo has expired' - I'll get the glory for that one :o)

[sebastfr]

On 20/01/14 17:31, jesusbagpuss wrote:

👊
I'm thinking about making a 'pre-expiry-warning' rather than just a
'your embargo has expired' - I'll get the glory for that one :o)

—
Reply to this email directly or view it on GitHub
#190 (comment) Bug
from
https://github.com/notifications/beacon/912679__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNTc3MTkxMywiZGF0YSI6eyJpZCI6MjM4NjcyNDh9fQ==--cdbe455a60e846349b72c804ce8edbecc6ed1761.gif

haha love the facepunch :-)

this sounds like an interesting feature, def something for the core!