FIX: optional_callbacks #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eproxus
added a commit
that referenced
this pull request
Sep 7, 2015
Filter out optional_callbacks attributes
|
Thanks! Maybe it would be possible to whitelist instead of blacklist these attributes? |
|
Thank you for the merge. It can maybe do, but I'm not confident that can be implemented correctly. |
|
True, good point. Let's leave it like this for now then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a case that it cannot mock the module.
This module is defined optional callback, but it isn't export this this callback functions.
This pull request fix it, but it is not the best practice...=(