Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes was leave only callback. #154

Closed
wants to merge 1 commit into from

Conversation

soranoba
Copy link
Contributor

@soranoba soranoba commented Sep 9, 2015

please see #151

@eproxus
Copy link
Owner

eproxus commented Sep 9, 2015

Hmm, as you pointed out earlier, there are plenty of attributes that needs to be included. Some code will also rely on some attributes existing, so this is probably a bad idea.

@soranoba
Copy link
Contributor Author

soranoba commented Sep 9, 2015

I see.
I will close this pr.
Thanks for everything.

@soranoba soranoba closed this Sep 9, 2015
@eproxus
Copy link
Owner

eproxus commented Sep 10, 2015

I'm all open for better ideas on how to solve this though. I think most attributes won't produce any compiler errors, so maybe the manual approach is the best after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants