Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary updates and feature detection #22

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

myfonj
Copy link

@myfonj myfonj commented Jul 14, 2016

  • Introduce EQCSS.setStyle method according browser capabilities to overcome feature detection.
  • Prevent resetting styles without changes.

This should increase performance, and from my testing really "feels" significantly snappier :]

myfonj and others added 2 commits July 14, 2016 21:30
- Introduce EQCSS.setStyle method according browser capabilities to overcome feature detection.
- Prevent resetting styles without changes.

This should increase performance, and from my testing really "feels" significantly snappier :]
@tomhodgins
Copy link
Contributor

Hi @myfonj, Thanks for the contribution!

I've just created a 1.3.0 branch for this and a scroll fix I've been testing. Do you know how I could pull this into the 1.3.0 branch instead of into the gh-pages branch?

Fix scrolling on BODY or HTML elements IE9+
@myfonj
Copy link
Author

myfonj commented Jul 14, 2016

Oh, hi, thanks for kind response.

TBH I suck at git(hub): this was my first pull request ever -- realized that GH-pages would not be proper branch just after pressing "confirm", what a failure X|.

Seems that rebasing pull request is not possible, although quite demanded, so apparently the only option is closing this one and pulling (or cherrypicking (omg)) with another. (I've merged your 1.3.0 there without problem so I assume it should pass.) You can do it yourself now or I could open new request. Or ignore this and cram changes there manually: I wouldn't mind the missing link, and in fact I think maybe you'd like to change it anyway (eg that initialization in the domReady could be probably elsewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants