Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the target branch of a pull request #18

Closed
tjfontaine opened this issue Jun 4, 2013 · 1,519 comments
Closed

Change the target branch of a pull request #18

tjfontaine opened this issue Jun 4, 2013 · 1,519 comments

Comments

@tjfontaine
Copy link
Collaborator

@tjfontaine tjfontaine commented Jun 4, 2013

It can be necessary to pick a different target branch for a pull request if you accidentally select the wrong one, or perhaps you're asked to rebase the branch against a development branch vs a stable branch.

@thedrow
Copy link

@thedrow thedrow commented Jun 5, 2013

Oh this is much needed 👍

@jzaefferer
Copy link

@jzaefferer jzaefferer commented Jun 11, 2013

What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.

@thedrow
Copy link

@thedrow thedrow commented Jun 11, 2013

@jzaefferer There's nothing wrong with it. It's simply inconvenient.

@tjfontaine
Copy link
Collaborator Author

@tjfontaine tjfontaine commented Jun 11, 2013

It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane

@piedar
Copy link

@piedar piedar commented Jun 21, 2013

I too would appreciate this feature.

It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.

@prust

This comment was marked as spam.

8 similar comments
@amirnissim

This comment was marked as spam.

@bc-ben-buchanan

This comment was marked as spam.

@delliott90

This comment was marked as spam.

@anton-rudeshko

This comment was marked as spam.

@kuanxu

This comment was marked as spam.

@reinert

This comment was marked as spam.

@odedniv

This comment was marked as spam.

@sjaeckel

This comment was marked as spam.

@jaen
Copy link

@jaen jaen commented Sep 3, 2013

Also in favour.
Just did a pull request to wrong branch and ended up with the longest diff.

@kspangsege

This comment was marked as spam.

@marekmurawski

This comment was marked as spam.

1 similar comment
@mvdkleijn

This comment was marked as spam.

@nicwortel
Copy link

@nicwortel nicwortel commented Oct 2, 2013

👍 this would be a great improvement. I've sent an email to GitHub support, referencing to this issue.

@timpokorny

This comment was marked as spam.

@nicwortel
Copy link

@nicwortel nicwortel commented Oct 4, 2013

I received the following response from GitHub:

Thanks for your feedback about pull requests, Nic!

I've added your suggestions to our internal feature request list. We don't comment publicly about if or when we may implement a particular feature until it has shipped, however your feedback has definitely been recorded.

Let us know if you have any other suggestions.

Cheers,
Ivan

@mvdkleijn
Copy link

@mvdkleijn mvdkleijn commented Oct 4, 2013

I received the following response from GitHub:

That's their standard "we can't comment" reply. 😄

@ams2990

This comment was marked as spam.

@nathanbrauer

This comment was marked as spam.

@llvtt

This comment was marked as spam.

1 similar comment
@tchap

This comment was marked as spam.

@renatorib

This comment was marked as spam.

@camsaul
Copy link

@camsaul camsaul commented Aug 4, 2016

Dear GitHub,

This is a BASIC need for all users. PLEASE do it.

@Myoldmopar
Copy link

@Myoldmopar Myoldmopar commented Aug 4, 2016

@levithomason
Copy link

@levithomason levithomason commented Aug 5, 2016

I don't think this is purely a convenience issue.

Some tools, like github_changelog_generator, use the issues and PRs to generate a CHANGELOG. This means erroneous PRs are forever locked in to the CHANGELOG.

Repo metric tools like Pulse and 3rd party tools like http://isitmaintained.com are also thrown off as PRs had to be closed aren't actually resolved. They were closed to change the target branch only.

Without the ability to delete a PR, or change the base branch, our only option is to make a mess of it. That sucks :/ We're developers, we love accuracy and correctness.

Comments are also not carried over. So when you change the target branch after considerable work and comments have been made, you loose all the context. This also sucks as you now have to copy comments over or reference both PRs.

Also, it is super inconvenient. Still ❤️ you, but fix it.

@tjohnell-handy

This comment was marked as spam.

1 similar comment
@claydonkey
Copy link

@claydonkey claydonkey commented Aug 8, 2016

+1

@TPS
Copy link
Collaborator

@TPS TPS commented Aug 9, 2016

@levithomason Did you send that lovely piece off to GitHub support & refer them back here? That's the best I've ever seen it requested!

@claydonkey
Copy link

@claydonkey claydonkey commented Aug 9, 2016

@TPS why you thumb me down dude?

@TPS
Copy link
Collaborator

@TPS TPS commented Aug 9, 2016

@claydonkey
Copy link

@claydonkey claydonkey commented Aug 9, 2016

Wow I thought I had time to waste...
So I put a thumbs up on the initial post but I spose the self posted +1s are working if people are getting irritated.

@btamayo
Copy link

@btamayo btamayo commented Aug 15, 2016

@domino14
Copy link

@domino14 domino14 commented Aug 15, 2016

Finally! May this be the last comment on this thread.

@TPS
Copy link
Collaborator

@TPS TPS commented Aug 16, 2016

@tjfontaine (OP) @cirosantilli @ALL I hope that https://github.com/blog/2224-change-the-base-branch-of-a-pull-request (from #18 (comment)) means that this can be closed FTW. Else, could someone post what's missing?

(Sorry, @domino14. 😉)

@beldaGR
Copy link

@beldaGR beldaGR commented Aug 24, 2016

I experienced this problem: #750
Changed base branch but Github's visual diff did not change. After merging, previously reverted commits show up.

@XedinUnknown
Copy link

@XedinUnknown XedinUnknown commented Dec 1, 2016

How about giving admins the ability to change the target of a PR that someone else created?

@JimLiu
Copy link

@JimLiu JimLiu commented Jan 12, 2017

Is this the most commented issue on Github?

@biolau
Copy link

@biolau biolau commented Feb 16, 2017

Competitors have it just add it please!!!
+1

@rhutchison
Copy link

@rhutchison rhutchison commented Feb 16, 2017

@biolau it's implemented

@cirosantilli added the implemented label on Aug 16, 2016

@tjohnell-handy
Copy link

@tjohnell-handy tjohnell-handy commented Feb 16, 2017

I motion for the original comment to be edited with the update of implementation so this "thread" can be forever buried. Sorry to the hundreds of people who just got this email.

@domino14
Copy link

@domino14 domino14 commented Feb 16, 2017

Repository owner locked and limited conversation to collaborators Feb 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.