New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the target branch of a pull request #18

Closed
tjfontaine opened this Issue Jun 4, 2013 · 1,519 comments

Comments

Projects
None yet
@tjfontaine
Collaborator

tjfontaine commented Jun 4, 2013

It can be necessary to pick a different target branch for a pull request if you accidentally select the wrong one, or perhaps you're asked to rebase the branch against a development branch vs a stable branch.

@thedrow

This comment has been minimized.

Show comment
Hide comment
@thedrow

thedrow Jun 5, 2013

Oh this is much needed 👍

thedrow commented Jun 5, 2013

Oh this is much needed 👍

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Jun 11, 2013

What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.

What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.

@thedrow

This comment has been minimized.

Show comment
Hide comment
@thedrow

thedrow Jun 11, 2013

@jzaefferer There's nothing wrong with it. It's simply inconvenient.

thedrow commented Jun 11, 2013

@jzaefferer There's nothing wrong with it. It's simply inconvenient.

@tjfontaine

This comment has been minimized.

Show comment
Hide comment
@tjfontaine

tjfontaine Jun 11, 2013

Collaborator

It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane

Collaborator

tjfontaine commented Jun 11, 2013

It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane

@piedar

This comment has been minimized.

Show comment
Hide comment
@piedar

piedar Jun 21, 2013

I too would appreciate this feature.

It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.

piedar commented Jun 21, 2013

I too would appreciate this feature.

It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.

@prust

This comment has been minimized.

Show comment
Hide comment

prust commented Jul 1, 2013

👍

@amirnissim

This comment has been minimized.

Show comment
Hide comment

+1

@bc-ben-buchanan

This comment has been minimized.

Show comment
Hide comment

+1

@delliott90

This comment has been minimized.

Show comment
Hide comment

+1

@anton-rudeshko

This comment has been minimized.

Show comment
Hide comment

+1

@kuanxu

This comment has been minimized.

Show comment
Hide comment

kuanxu commented Aug 29, 2013

+1

@reinert

This comment has been minimized.

Show comment
Hide comment

reinert commented Aug 30, 2013

+1

@odedniv

This comment has been minimized.

Show comment
Hide comment

odedniv commented Aug 31, 2013

+1

@sjaeckel

This comment has been minimized.

Show comment
Hide comment

sjaeckel commented Sep 3, 2013

👍

@jaen

This comment has been minimized.

Show comment
Hide comment
@jaen

jaen Sep 3, 2013

Also in favour.
Just did a pull request to wrong branch and ended up with the longest diff.

jaen commented Sep 3, 2013

Also in favour.
Just did a pull request to wrong branch and ended up with the longest diff.

@kspangsege

This comment has been minimized.

Show comment
Hide comment

👍

@marekmurawski

This comment has been minimized.

Show comment
Hide comment

👍

@mvdkleijn

This comment has been minimized.

Show comment
Hide comment

👍

@nicwortel

This comment has been minimized.

Show comment
Hide comment
@nicwortel

nicwortel Oct 2, 2013

👍 this would be a great improvement. I've sent an email to GitHub support, referencing to this issue.

👍 this would be a great improvement. I've sent an email to GitHub support, referencing to this issue.

@timpokorny

This comment has been minimized.

Show comment
Hide comment

+1

@nicwortel

This comment has been minimized.

Show comment
Hide comment
@nicwortel

nicwortel Oct 4, 2013

I received the following response from GitHub:

Thanks for your feedback about pull requests, Nic!

I've added your suggestions to our internal feature request list. We don't comment publicly about if or when we may implement a particular feature until it has shipped, however your feedback has definitely been recorded.

Let us know if you have any other suggestions.

Cheers,
Ivan

I received the following response from GitHub:

Thanks for your feedback about pull requests, Nic!

I've added your suggestions to our internal feature request list. We don't comment publicly about if or when we may implement a particular feature until it has shipped, however your feedback has definitely been recorded.

Let us know if you have any other suggestions.

Cheers,
Ivan

@mvdkleijn

This comment has been minimized.

Show comment
Hide comment
@mvdkleijn

mvdkleijn Oct 4, 2013

I received the following response from GitHub:

That's their standard "we can't comment" reply. 😄

I received the following response from GitHub:

That's their standard "we can't comment" reply. 😄

@ams2990

This comment has been minimized.

Show comment
Hide comment

ams2990 commented Oct 10, 2013

+1

@kspangsege kspangsege referenced this issue in realm/realm-core Oct 12, 2013

Merged

Fixed string_leak #233

@nathanbrauer

This comment has been minimized.

Show comment
Hide comment

👍

@llvtt

This comment has been minimized.

Show comment
Hide comment

llvtt commented Nov 7, 2013

+1

@tchap

This comment has been minimized.

Show comment
Hide comment

tchap commented Nov 9, 2013

👍

@avit avit referenced this issue in rails/arel Nov 12, 2013

Closed

Release 3.0.3 #218

@ghost

This comment has been minimized.

Show comment
Hide comment

ghost commented Nov 15, 2013

+1

@gr2m

This comment has been minimized.

Show comment
Hide comment

gr2m commented Nov 15, 2013

👍

@gauteh

This comment has been minimized.

Show comment
Hide comment
@gauteh

gauteh Nov 21, 2013

👍 for gods sake.

gauteh commented Nov 21, 2013

👍 for gods sake.

@thenbrent

This comment has been minimized.

Show comment
Hide comment

👍

@rGaillard

This comment has been minimized.

Show comment
Hide comment

+1

@aarana-ix

This comment has been minimized.

Show comment
Hide comment

+1

@gaillafr

This comment has been minimized.

Show comment
Hide comment

+1

@patrickkettner patrickkettner referenced this issue in Modernizr/Modernizr Nov 29, 2013

Closed

Add saucelab unit testing support #1123

@snowwlex

This comment has been minimized.

Show comment
Hide comment

+1

@ranjaykrishna

This comment has been minimized.

Show comment
Hide comment

+1

@fandy

This comment has been minimized.

Show comment
Hide comment
@fandy

fandy Jul 27, 2016

I think we'll need more +1s to move forward.

fandy commented Jul 27, 2016

I think we'll need more +1s to move forward.

@btamayo

This comment has been minimized.

Show comment
Hide comment
@btamayo

btamayo Jul 27, 2016

If you need more +1s, here's mine:

+1

btamayo commented Jul 27, 2016

If you need more +1s, here's mine:

+1

@ClementVidal

This comment has been minimized.

Show comment
Hide comment

+1

@etanshaul

This comment has been minimized.

Show comment
Hide comment

👍

@etanshaul etanshaul referenced this issue in GoogleCloudPlatform/google-cloud-intellij Jul 28, 2016

Merged

Merge JetBrains plugin integration into master #798

@wedgybo wedgybo referenced this issue in serverless/serverless Jul 29, 2016

Closed

Global template vars #1710

@h0tw1r3 h0tw1r3 referenced this issue in libuv/libuv Jul 29, 2016

Closed

GNU/kFreeBSD support #959

@tlrobinson

This comment has been minimized.

Show comment
Hide comment

image

@sljavi

This comment has been minimized.

Show comment
Hide comment

sljavi commented Aug 2, 2016

👍

@renatorib

This comment has been minimized.

Show comment
Hide comment

👍

@camsaul camsaul referenced this issue in metabase/metabase Aug 4, 2016

Closed

fix #3105: Title in User guide page #3122

1 of 1 task complete
@camsaul

This comment has been minimized.

Show comment
Hide comment
@camsaul

camsaul Aug 4, 2016

Dear GitHub,

This is a BASIC need for all users. PLEASE do it.

camsaul commented Aug 4, 2016

Dear GitHub,

This is a BASIC need for all users. PLEASE do it.

@Myoldmopar

This comment has been minimized.

Show comment
Hide comment
@Myoldmopar

Myoldmopar Aug 4, 2016

@pelya pelya referenced this issue in SuperTux/supertux Aug 5, 2016

Closed

More arcade-looking Yeti death sequence #520

@levithomason levithomason referenced this issue in garris/BackstopJS Aug 5, 2016

Closed

WIP : Move Gulp tasks to custom CLI #164 #232

@levithomason

This comment has been minimized.

Show comment
Hide comment
@levithomason

levithomason Aug 5, 2016

I don't think this is purely a convenience issue.

Some tools, like github_changelog_generator, use the issues and PRs to generate a CHANGELOG. This means erroneous PRs are forever locked in to the CHANGELOG.

Repo metric tools like Pulse and 3rd party tools like http://isitmaintained.com are also thrown off as PRs had to be closed aren't actually resolved. They were closed to change the target branch only.

Without the ability to delete a PR, or change the base branch, our only option is to make a mess of it. That sucks :/ We're developers, we love accuracy and correctness.

Comments are also not carried over. So when you change the target branch after considerable work and comments have been made, you loose all the context. This also sucks as you now have to copy comments over or reference both PRs.

Also, it is super inconvenient. Still ❤️ you, but fix it.

levithomason commented Aug 5, 2016

I don't think this is purely a convenience issue.

Some tools, like github_changelog_generator, use the issues and PRs to generate a CHANGELOG. This means erroneous PRs are forever locked in to the CHANGELOG.

Repo metric tools like Pulse and 3rd party tools like http://isitmaintained.com are also thrown off as PRs had to be closed aren't actually resolved. They were closed to change the target branch only.

Without the ability to delete a PR, or change the base branch, our only option is to make a mess of it. That sucks :/ We're developers, we love accuracy and correctness.

Comments are also not carried over. So when you change the target branch after considerable work and comments have been made, you loose all the context. This also sucks as you now have to copy comments over or reference both PRs.

Also, it is super inconvenient. Still ❤️ you, but fix it.

@tjohnell-handy

This comment has been minimized.

Show comment
Hide comment

+1

@claydonkey

This comment has been minimized.

Show comment
Hide comment

+1

@sunyab sunyab referenced this issue in PixarAnimationStudios/USD Aug 8, 2016

Closed

fix URL link - capitalization counts in this one #8

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 9, 2016

@levithomason Did you send that lovely piece off to GitHub support & refer them back here? That's the best I've ever seen it requested!

TPS commented Aug 9, 2016

@levithomason Did you send that lovely piece off to GitHub support & refer them back here? That's the best I've ever seen it requested!

@claydonkey

This comment has been minimized.

Show comment
Hide comment
@claydonkey

claydonkey Aug 9, 2016

@TPS why you thumb me down dude?

@TPS why you thumb me down dude?

@TPS

This comment has been minimized.

Show comment
Hide comment

TPS commented Aug 9, 2016

@claydonkey

This comment has been minimized.

Show comment
Hide comment
@claydonkey

claydonkey Aug 9, 2016

Wow I thought I had time to waste...
So I put a thumbs up on the initial post but I spose the self posted +1s are working if people are getting irritated.

Wow I thought I had time to waste...
So I put a thumbs up on the initial post but I spose the self posted +1s are working if people are getting irritated.

@ivan-mogilko ivan-mogilko referenced this issue in adventuregamestudio/ags-template-source Aug 15, 2016

Closed

Fixed transparency on sprite 2008 #1

@btamayo

This comment has been minimized.

Show comment
Hide comment

btamayo commented Aug 15, 2016

@domino14

This comment has been minimized.

Show comment
Hide comment
@domino14

domino14 Aug 15, 2016

Finally! May this be the last comment on this thread.

Finally! May this be the last comment on this thread.

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Aug 16, 2016

@tjfontaine (OP) @cirosantilli @ALL I hope that https://github.com/blog/2224-change-the-base-branch-of-a-pull-request (from #18 (comment)) means that this can be closed FTW. Else, could someone post what's missing?

(Sorry, @domino14. 😉)

TPS commented Aug 16, 2016

@tjfontaine (OP) @cirosantilli @ALL I hope that https://github.com/blog/2224-change-the-base-branch-of-a-pull-request (from #18 (comment)) means that this can be closed FTW. Else, could someone post what's missing?

(Sorry, @domino14. 😉)

@beldaGR

This comment has been minimized.

Show comment
Hide comment
@beldaGR

beldaGR Aug 24, 2016

I experienced this problem: #750
Changed base branch but Github's visual diff did not change. After merging, previously reverted commits show up.

beldaGR commented Aug 24, 2016

I experienced this problem: #750
Changed base branch but Github's visual diff did not change. After merging, previously reverted commits show up.

@XedinUnknown

This comment has been minimized.

Show comment
Hide comment
@XedinUnknown

XedinUnknown Dec 1, 2016

How about giving admins the ability to change the target of a PR that someone else created?

How about giving admins the ability to change the target of a PR that someone else created?

@JimLiu

This comment has been minimized.

Show comment
Hide comment
@JimLiu

JimLiu Jan 12, 2017

Is this the most commented issue on Github?

JimLiu commented Jan 12, 2017

Is this the most commented issue on Github?

@biolau

This comment has been minimized.

Show comment
Hide comment
@biolau

biolau Feb 16, 2017

Competitors have it just add it please!!!
+1

biolau commented Feb 16, 2017

Competitors have it just add it please!!!
+1

@rhutchison

This comment has been minimized.

Show comment
Hide comment
@rhutchison

rhutchison Feb 16, 2017

@biolau it's implemented

@cirosantilli added the implemented label on Aug 16, 2016

@biolau it's implemented

@cirosantilli added the implemented label on Aug 16, 2016

@tjohnell-handy

This comment has been minimized.

Show comment
Hide comment
@tjohnell-handy

tjohnell-handy Feb 16, 2017

I motion for the original comment to be edited with the update of implementation so this "thread" can be forever buried. Sorry to the hundreds of people who just got this email.

I motion for the original comment to be edited with the update of implementation so this "thread" can be forever buried. Sorry to the hundreds of people who just got this email.

@domino14

This comment has been minimized.

Show comment
Hide comment
@domino14

domino14 Feb 16, 2017

Repository owner locked and limited conversation to collaborators Feb 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.