Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQStream drops connections before they can be properly established #300

Closed
emagi opened this issue Nov 23, 2014 · 2 comments
Closed

EQStream drops connections before they can be properly established #300

emagi opened this issue Nov 23, 2014 · 2 comments

Comments

@emagi
Copy link

emagi commented Nov 23, 2014

EQEmu code isn't conforming to client specification. Client attempts one initial OP_SessionRequest plus 3 retries. Currently if OP_SessionRequest is received more than once EQEmu will disconnect the client from the server.

Changes are being tested, since this is intermittent it will require a good period of time to test.

http://pastebin.com/HWGKsadT

@emagi
Copy link
Author

emagi commented Nov 24, 2014

I have Secrets looking at this one -- and also after further review it looks like we can have even higher 'retry' attempts on OP_SessionRequest. So the ''5'' value should be probably '30' which is what I originally defaulted on my server. I had a client coming in from Hawaii that hit OP_SessionRequest 7x, but then successfully connected.

@Akkadius
Copy link
Member

diff added and applied, verified huge improvement, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants