Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of non OK HTTP status codes in injector #3

Open
inetic opened this issue Dec 14, 2017 · 1 comment
Open

Better handling of non OK HTTP status codes in injector #3

inetic opened this issue Dec 14, 2017 · 1 comment

Comments

@inetic
Copy link
Member

inetic commented Dec 14, 2017

At the moment, when the injector receives a message from the origin, it only checks the error code. But this error code has nothing to do with the response HTTP status code.

We need to check that, and handle non OK responses appropriately.

Sample 304 response I found in the cache:

HTTP/1.1 304 Not Modified
Content-Type: image/png
Last-Modified: Tue, 03 Jan 2017 21:29:30 GMT
Cache-Control: max-age=1661425
Expires: Tue, 02 Jan 2018 16:25:41 GMT
Date: Thu, 14 Dec 2017 10:55:16 GMT
Connection: keep-alive
Access-Control-Allow-Methods: GET
Access-Control-Allow-Origin: *
inetic added a commit that referenced this issue Dec 14, 2017
@inetic
Only store in cache when OK response is received
1dc1e70 
This is a temporary workaround for
#3
inetic added a commit that referenced this issue Dec 14, 2017
@inetic
Only store in cache when OK response is received
cb31fe4 
This is a temporary workaround for
#3
@inetic
Copy link
Member Author

inetic commented Dec 14, 2017

I added first workaround to only store HTTP/OK responses for now:

cb31fe4

inetic added a commit that referenced this issue Jun 1, 2020
@inetic
Announcer: fix possible reason for announcer to stop
b583c0e 
I could have happened as such:

1. Cache adds foo.bar to the announcer
2. User hits the "purge cache" button and foo.bar is marked for removal
   after some delay
3. Cache adds foo.bar to the announcer again, but nothing happens because
   foo.bar is already there (although marked for removal)
4. Time passes and announcer removes foo.bar

Solution:
* Unmark foo.bar's removal flag in step #3 above
ouinet-bot pushed a commit that referenced this issue Mar 15, 2023
@orignal
Merge pull request #3 from equalitie/master
2f3d256 
update from upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inetic