Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link_blank rule allowed phrases #650

Merged
merged 1 commit into from
May 30, 2024

Conversation

SteveJonesDev
Copy link
Member

The PR simplifies the allowed phases used in the Link Opens New Window or Tab rule check.

Closes #629

@SteveJonesDev SteveJonesDev added the enhancement New feature or request label May 30, 2024
@SteveJonesDev SteveJonesDev added this to the v1.14.0 milestone May 30, 2024
@SteveJonesDev SteveJonesDev changed the title updated - link_blank rule allowed phrases Updated link_blank rule allowed phrases May 30, 2024
Copy link
Member

@pattonwebz pattonwebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveJonesDev SteveJonesDev merged commit b18ae20 into develop May 30, 2024
16 checks passed
@SteveJonesDev SteveJonesDev deleted the steve/629/open-in-new-window-phrases branch May 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making the check for links that open in new window more generic
2 participants