Don't operate on JS rules when doing rulecheck for php ruleset #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveJonesDev
approved these changes
Jun 5, 2024
pattonwebz
deleted the
william/655/avoid-deleting-js-issues-during-rulecheck-when-the-scan-is-not-the-js-rules-can
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a change that excludes the JS rules from the PHP rule check flow when a post is updated. It prevents any JS rule issues from being deleted from the database at the end of the PHP scan (they will still be deleted if corrected when the JS scan runs).
This solves the issue reported that specific ignored issues (investigating, I found that it was all JS rules subject to this bug) would return when posts were updated and no longer be ignored.
Fixes: #655