Keep arguments to nvim before any filenames; fixes #417.

[roflcopter4]

As noted in issue #417, Neovim v3.* inexplicably seems to open an empty buffer when option parameters appear after filenames. This could be solved by adding a -- parameter before the filenames, but the easier thing to do is to simply move nvim-qt's additional arguments before any user specified ones and let Neovim sort out this strange bug. Although it may not be 100% reproducible, at least a few people besides myself have noticed this, and this tiny patch seems to fix it without causing any problems I can think of, so it should be harmless at worst.

I also added one small comment (and initially committed with spaces instead of tabs: fixed).

EDIT: I have absolutely no idea why the build failed in the Windows test environment. I didn't change anything that has anything to do with that... I barely changed anything at all.

[justinmk]

Did you try latest Nvim HEAD? As mentioned in #417 (comment) I am wondering if neovim/neovim#8576 (which was merged yesterday) resolves this without the need for a workaround in nvim-qt.

This would be helpful to know because it may affect other GUIs.

[justinmk]

This comment is definitely true, and if something like this was being constructed before:

nvim -- --embed --headless

Then nvim should have opened files literally named --embed and --headless.

[roflcopter4]

It was certainly worth a shot to recompile nvim (which in Gentoo takes all of emerge neovim to source, compile and install -- I love Gentoo). It didn't help. Nvim-qt with my little patch works, but without it a blank buffer is still opened. The only other Nvim gui that that I can think of that isn't utter garbage is Eovim (which is too buggy to use, and uses EFL which has awful font support) doesn't suffer any problems either way.

The arguments nvim-qt was supplying previously looked like

--cmd "let &rtp.=',/usr/local/share/nvim-qt/runtime'" --cmd "set termguicolors" FILE_GOES_HERE --embed --headless

while this patch changes it to

--embed --headless --cmd "let &rtp.=',/usr/local/share/nvim-qt/runtime'" --cmd "set termguicolors" FILE_GOES_HERE

(I hacked in a debug statement that dumped the arguments to the command line just to be sure). In neither case does -- appear. That's why I consider it a bug in nvim. Both should work without problems. The only explanation I can think of is a problem in neovim's option parsing. Regardless, putting everything before the files is a functional temporary fix.

[justinmk]

Thanks. It definitely would be a Nvim bug, but I can't reproduce it. I tried this:

NVIM_LISTEN_ADDRESS=foo nvim --cmd "let &rtp.=''" --cmd "set termguicolors" README.md --embed --headless

Then connect to the foo server with the python client:

>>> import neovim
>>> n = neovim.attach('socket', path='foo')
>>> n.request('nvim_command_output', 'ls!')
'  1 %a   "README.md"                    line 1'

[roflcopter4]

I couldn't say why you can't seem to reproduce this. It doesn't make much sense to me in general anyway. Very strange. Are you using the latest build of Neovim?

[justinmk]

Yes, Nvim HEAD.

[justinmk]

@equalsraf If you have a chance, would be helpful to get a tagged release which includes this fix, so that Nvim can ship it to Windows users.

[equalsraf]

Tag in place but it seems appveyor builds are broken.