Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong port number used when disable i8259 PIC #4

Open
equation314 opened this issue May 3, 2023 · 1 comment
Open

Wrong port number used when disable i8259 PIC #4

equation314 opened this issue May 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@equation314
Copy link
Owner

RVM-Tutorial/hypervisor/src/arch/x86_64/lapic.rs

Lines 22 to 26 in 7687541

unsafe {
// Disable 8259A interrupt controllers
Port::<u8>::new(0x20).write(0xff);
Port::<u8>::new(0xA0).write(0xff);
}

Should be

 Port::<u8>::new(0x21).write(0xff); 
 Port::<u8>::new(0xA1).write(0xff);
@equation314 equation314 changed the title Wrong port number used when disable PIC Wrong port number used when disable i8259 PIC May 3, 2023
@equation314 equation314 added the bug Something isn't working label Sep 10, 2023
equation314 added a commit that referenced this issue Sep 10, 2023
@equation314
Fix wrong port number when disable i8259 PIC (#4)
95b0675
@equation314
Copy link
Owner Author

Fixed in 95b0675.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@equation314