Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test in coverage #11

Merged
merged 1 commit into from Jul 6, 2023
Merged

Fix test in coverage #11

merged 1 commit into from Jul 6, 2023

Conversation

0xfennel
Copy link
Contributor

@0xfennel 0xfennel commented Jul 6, 2023

I think the issue has something to do with sc-forks/solidity-coverage#652 and sc-forks/solidity-coverage#707

There might still be one test that's failing. The failure is flaky on my machine and difficult to reproduce consistently, so I'll leave it for now...

@0xfennel 0xfennel requested a review from kbrizzle July 6, 2023 19:11
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

[Payoff] Unit Test Code Coverage Report

Coverage after merging fennel/coverage into main will be
20.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-payoff/contracts
   PayoffFactory.sol0%0%0%0%12, 12–13, 16, 16–17
packages/perennial-payoff/contracts/interfaces
   IPayoffFactory.sol100%100%100%100%
   IPayoffProvider.sol100%100%100%100%
packages/perennial-payoff/contracts/payoff
   Giga.sol0%100%0%100%
   Kilo.sol0%100%0%100%
   KiloPowerHalf.sol0%100%0%0%11
   KiloPowerTwo.sol0%100%0%100%
   Mega.sol0%100%0%100%
   MegaPowerTwo.sol0%100%0%100%
   Micro.sol0%100%0%100%
   MicroPowerTwo.sol0%100%0%100%
   Milli.sol0%100%0%100%
   MilliPowerHalf.sol0%100%0%0%11
   MilliPowerTwo.sol100%100%100%100%
   Nano.sol0%100%0%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

[Payoff] Integration Test Code Coverage Report

Coverage after merging fennel/coverage into main will be
20.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-payoff/contracts
   PayoffFactory.sol0%0%0%0%12, 12–13, 16, 16–17
packages/perennial-payoff/contracts/interfaces
   IPayoffFactory.sol100%100%100%100%
   IPayoffProvider.sol100%100%100%100%
packages/perennial-payoff/contracts/payoff
   Giga.sol0%100%0%100%
   Kilo.sol0%100%0%100%
   KiloPowerHalf.sol0%100%0%0%11
   KiloPowerTwo.sol0%100%0%100%
   Mega.sol0%100%0%100%
   MegaPowerTwo.sol0%100%0%100%
   Micro.sol0%100%0%100%
   MicroPowerTwo.sol0%100%0%100%
   Milli.sol0%100%0%100%
   MilliPowerHalf.sol0%100%0%0%11
   MilliPowerTwo.sol100%100%100%100%
   Nano.sol0%100%0%100%
   PowerHalf.sol100%100%100%100%
   PowerTwo.sol100%100%100%100%

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

[Oracle] Unit Test Coverage Report

Coverage after merging fennel/coverage into main will be
25.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/perennial-oracle/contracts
   Oracle.sol93.06%85.71%100%96.97%12, 23, 64, 82–83
   OracleFactory.sol0%0%0%0%27, 27–28, 30, 33, 33–34, 37, 37–38, 41, 41–42, 42, 42–43, 43, 43, 45–46, 46, 46, 48–49, 51, 54, 54–55, 55, 55–56, 56, 56, 58–59, 59, 59, 61–62, 65, 65–67, 71, 71, 71–72, 72, 72–73, 79–81, 81, 81–82
packages/perennial-oracle/contracts/interfaces
   IOracle.sol100%100%100%100%
   IOracleFactory.sol100%100%100%100%
   IOracleProvider.sol100%100%100%100%
   IOracleProviderFactory.sol100%100%100%100%
   IPythFactory.sol100%100%100%100%
   IPythOracle.sol100%100%100%100%
packages/perennial-oracle/contracts/pyth
   PythFactory.sol0%0%0%0%30, 30–31, 33–34, 37, 37–38, 41, 41, 44–45, 47, 50, 50–52, 56–58, 58, 58–59
   PythOracle.sol0%0%0%0%102, 110, 110, 110, 112, 120, 129–130, 142, 142, 147, 147, 147–148, 148, 148, 150–151, 153, 153, 153–154, 157, 157, 157–158, 160, 160, 160, 163, 163, 163, 169–171, 177, 181, 181, 181–182, 185, 185, 185, 187–188, 196–199, 201, 213, 215, 219, 221, 223–224, 230–231, 235, 235, 235–236, 70–72, 79, 79–80, 82, 82, 82, 84, 90, 90–91, 91, 91, 91, 91–92
packages/perennial-oracle/contracts/reference
   ReferenceKeeperOracle.sol0%0%0%0%17, 17, 17, 21, 25, 25, 25, 25, 25, 25, 25–27, 27, 27–28, 32, 32, 32–33, 38, 38
packages/perennial-oracle/contracts/types
   OracleVersion.sol100%100%100%100%

@0xfennel 0xfennel merged commit 114b0b1 into main Jul 6, 2023
4 of 9 checks passed
@0xfennel 0xfennel deleted the fennel/coverage branch July 6, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants