Overridden gas price does not work in London fork

[ZumZoom]

solidity-coverage/lib/api.js

Line 55 in 3c0f3a5

this.gasPrice = 0x01;

Solidity-coverage overrides gasPrice and sets it to 1 wei. This behaviour was acceptable before London hardfork but now coverage fails with
Transaction gasPrice (1) is too low for the next block, which has a baseFeePerGas of 73433802882

I understand the reasoning behind overriding gas and blockGasLimit, but I think gasPrice should not be overridden anymore.

[PaulRBerg]

Hey @cgewecke! Sorry to tag you, but this seems to be an urgent issue. Any chance you could remove the this.gasPrice = 0x01 line and ship a fixed version of solidity-coverage?

We'd all be very grateful.

[alcuadrado]

One possible workaround would be to use set the initial base fee per gas to 0.

networks: {
    hardhat: {
      initialBaseFeePerGas: 0
    }
  }

There's a small chance of this not working, but I think it'd work in most of the cases.

[PaulRBerg]

Another workaround is to set an environment variable as a flag and regress to the berlin hardfork in your Hardhat Network configuration when that flag is set. E.g. how I do it in my solidity-template:

hardhat: {
  hardfork: process.env.CODE_COVERAGE ? "berlin" : "london",
}

Of course, this is not great, because running test coverage on different EVMs might produce different results. But it's good enough as a temporary solution.

[alcuadrado]

There's a small chance of this not working, but I think it'd work in most of the cases.

I should have given more info here. This may not work because sendings txs that use more than 50% of the block gas limit would result in the next block having a larger base fee. Most the time, given the math of eip1559, this would still result in the next base fee being 0 or 1. But if this happens for a few blocks in a row, it may result in base fees greater than 1, and the og problem will happen.

[MoMannn]

👍