Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Workflows for CI tests and goreleaser based releases #47

Merged
merged 9 commits into from
Aug 12, 2020

Conversation

displague
Copy link
Member

This PR is doing a few things, happy to break it out if needed:

  • update packngo to latest
  • add a custom UserAgent to packngo API calls with the docker-machine-driver-packet release tag
  • add linting checks as a github workflow
  • add goreleaser as a github workflow task
  • add release badges to the README.md
  • ignore .vscode/ in git

@displague displague force-pushed the workflows branch 2 times, most recently from 0f3a553 to 5cd9a3e Compare August 12, 2020 18:59
@displague
Copy link
Member Author

tested with:

  • golangci-lint run .
  • goimports -w .
  • go test -v ./...
  • goreleaser check
  • goreleaser build
  • act -P ubuntu-latest=nektos/act-environments-ubuntu:18.04

Ultimately verified by merging and tagging this into the master of my fork, where the workflow succeeded in producing a release and running all of the tests.

@displague
Copy link
Member Author

While testing that the binary worked, I found that the User-Agent was not being transmitted. Not the fault of this branch, but of equinixmetal-archive/packngo#188.

This may help anyone else looking to debug this plugin:

go build
PACKNGO_DEBUG=1 PATH=`pwd`:$PATH docker-machine \
  --debug create -d packet \
  --packet-api-key=$PACKET_TOKEN \
  --packet-project-id=$PACKET_PROJECT \
  foo

@displague displague merged commit 4ba9d3c into equinix:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant