Bugfix/select all crashes #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a crash that occurs when clicking select all 'too' quickly which otherwise can trigger an infinite loop inside this useEffect.
|
Some important caveats:
|
oddvernes
approved these changes
May 7, 2024
There was a problem hiding this comment.
While it is a bit unnerving to not know what problem this particular bit of code was supposed to solve (guessing in the past, selectedOptions sent into the Autocomplete on load did not get set initially, or something like that, perhaps a bug with downshift 🤷♂️), I am unable to find any problems with removing it, so lets do it 👍
mhwaage
added a commit
to mhwaage/design-system
that referenced
this pull request
Jul 29, 2024
* Move toggleAllSelected so it is clear which variables it is using * Remove deeply suspicious useEffect This resolves a crash that occurs when clicking select all 'too' quickly which otherwise can trigger an infinite loop inside this useEffect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a seemingly unnecessary useEffect, which resolves an issue where choosing select all would crash when clicked twice in rapid succession. (#3426)