fix: add protocol to type returned from JobHandlerPicker #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianKjerstad
force-pushed
the
fix/bug-in-JobHandlerPicker
branch
from
dafdd9b
to
ba78f1f
Compare
KristianKjerstad
requested review from
netr0m,
soofstad,
eoaksnes and
ingeridhellen
as code owners
soofstad
requested changes
Mar 1, 2023
| @@ -26,7 +27,7 @@ export const JobHandlerPicker = (props: { | |||
| absoluteId: `WorkflowDS/${blueprintId}`, | |||
| }) | |||
| .then((response: any) => { | |||
| onChange(response.data) | |||
| onChange(`${protocolPrefix}${response.data}`) | |||
There was a problem hiding this comment.
Should we not rather fix DMSS to return a path with the correct protocol prefix?
There was a problem hiding this comment.
mm, yeah. That makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
fix bug in JobHandlerPicker.
JobHandlerPicker is used in Analysis platform
the blueprintResolve endpoint in dmss return only a path
the protocol should be added since JobHandlerPicker returns a type
Why is this pull request needed?
bug
Issues related to this change
make analysis platform work again
closes #106