Support new and future versions of configsuite #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
force-pushed
the
config_pandas
branch
2 times, most recently
from
6430dc4
to
f2701cf
Compare
anders-kiaer
changed the title
anders-kiaer
force-pushed
the
config_pandas
branch
from
f2701cf
to
7fcc6c5
Compare
anders-kiaer
force-pushed
the
config_pandas
branch
from
7fcc6c5
to
4258e26
Compare
anders-kiaer
changed the title
wouterjdb
approved these changes
Jul 12, 2020
There was a problem hiding this comment.
LGTM 👍
"Then in the 0.7 release deduce_required will default to None. If True is passed instead we will raise a deprecation warning and for any other value we will raise an exception. The idea is that in 0.7 you can safely stop setting deduce_required and then be ready for 0.8, where deduce_required will not be recognized as an optional argument anymore."
As we allow for the usage of configsuite >= 0.6 will end up in deprecation warnings by the time 0.7 is released. We will then need to update our code by removing deduce_required to not crash when version 0.8 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87 (following instructions in https://configsuite.readthedocs.io/en/stable/user_guide/deprecated_behaviour.html).