refactor: enable Typescript strict mode #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesadrian
reviewed
Jun 5, 2024
nesadrian
reviewed
Jun 6, 2024
nesadrian
reviewed
Jun 6, 2024
|
We should go through all the api files and set the correct return types. It will be easier to determine the types of the rest of the application after doing this. If you want to do this separately then please make an issue for this. |
# Conflicts: # components/DurationComponent.tsx # components/SideBarBody.tsx
I have reviewed the API models and updated any types in the frontend that were missing or mismatched. Should be good now afaik |
nesadrian
previously approved these changes
Jun 10, 2024
nesadrian
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all strict errors. There are still a few "anys" that give warnings though.