Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ForwardModelStep class #69

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

adnejacobsen
Copy link
Contributor

@adnejacobsen adnejacobsen commented May 27, 2024

A PR in Ert is introducing a ForwardModelStep class that allows for pre-experiment and pre-realization validation.

Using these new features we can check if the user is authenticated when launching Ert.

I have looked at this PR in semeio for how to set this up.

I have kept the old SUMO_UPLOADER Ert config, but I suspect it can be deleted. I have only tested the validation part of this locally and have not confirmed that the uploader still functions as expected. We will have to do some more testing on RGS when these features are available in Ert.

@adnejacobsen
Copy link
Contributor Author

Also: I have not been able to pickup the value of SUMO_ENV when defined using the DEFINE keyword. It only shows up in private_args if passed directly to the SUMO_UPLOAD forward model (SUMO_UPLOAD(<SUMO_ENV>="dev")).

Current solution: check for SUMO_ENV and default to prod if not found. This means that if someone has DEFINE <SUMO_ENV> dev in their config the validation method will check if the user is authenticated to prod and prevent Ert from launching even if the user is authenticated to dev.

@adnejacobsen
Copy link
Contributor Author

Also: I have not been able to pickup the value of SUMO_ENV when defined using the DEFINE keyword. It only shows up in private_args if passed directly to the SUMO_UPLOAD forward model (SUMO_UPLOAD(<SUMO_ENV>="dev")).

Current solution: check for SUMO_ENV and default to prod if not found. This means that if someone has DEFINE <SUMO_ENV> dev in their config the validation method will check if the user is authenticated to prod and prevent Ert from launching even if the user is authenticated to dev.

Update: The PR in Ert has been merged and some changes have been made. The validate_pre_experiment method now takes a fm_step_json parameter which lets us access the argsList. The argsList seems to be substituted and we can fetch the SUMO_ENV from here.

@adnejacobsen
Copy link
Contributor Author

adnejacobsen commented Jun 14, 2024

The new ForwardModelClass seems to replace the config file, so I have deprecated it. Tested in bleeding and works as expected.

@adnejacobsen adnejacobsen requested a review from a team June 14, 2024 11:29
Copy link
Collaborator

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adnejacobsen adnejacobsen merged commit a45c81b into main Jun 21, 2024
11 checks passed
@adnejacobsen adnejacobsen deleted the use-forward-model-step-class branch June 21, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants