Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml safe load #114

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Yaml safe load #114

merged 2 commits into from
Mar 12, 2024

Conversation

ErichSuter
Copy link
Contributor

Resolves: #111

@ErichSuter ErichSuter self-assigned this Mar 6, 2024
@mferrera
Copy link
Contributor

mferrera commented Mar 6, 2024 •
edited
Loading

Currently macOS runners seem to be bugged or broken so CI may not complete.

I think you should remove the CLN: prefix from the commit messages... that is not a convention on this repository or most FMU repositories and in I don't think we want it to become one on more than already have it (though we have not discussed this as a group).

@ErichSuter
Change yaml.load() to yaml.safe_load()
098f0f1 
Let internal YAML loader derive from yaml.SafeLoader instead of yaml.Loader.
Call yaml.safe_load() instead of yaml.load() where possible without larger updates.
@ErichSuter
Remove unused class _loader.YLoader
3d49bc4
@ErichSuter ErichSuter marked this pull request as ready for review March 11, 2024 16:54
mferrera
mferrera approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ErichSuter ErichSuter merged commit 9eb53c0 into equinor:main Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

Assignees

@ErichSuter ErichSuter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change yaml.load() to yaml.safe_load()
2 participants
@ErichSuter @mferrera