Correct dataio issues etc #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jcrivenaes
commented
Nov 22, 2022
jcrivenaes
commented
- Correct deprecations from xtgeo
- Fix issues wrt use fmu-datio in this package
- Improve the way tests that writes to documentation, is built (FYI, @vegardkv, the aggregation tests are slightly modified)
The tests now to generate the added YAML files can be generated with: pytest -k add2docs
perolavsvendsen
approved these changes
Nov 22, 2022
Thanks for the notification, @jcrivenaes . The changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.