Check for missing versions

komodo/release_cleanup.py

@@ -35,6 +35,16 @@ def find_unused_versions(used_versions, repository):
     return unused_versions
 
 
+def check_missing_versions(used_versions, repository):
+    unused_versions = {}
+    for lib, versions in used_versions.items():
+        for version in versions:
+            if lib not in repository or version not in repository[lib]:
+                raise ValueError(f"Missing used version {lib}=={version}")
+
+    return unused_versions
+
+
 def remove_unused_versions(repository, unused_versions):
     for lib, versions in unused_versions.items():
         for version in versions:
@@ -155,6 +165,7 @@ def run_cleanup(args, parser):
     release_files = [filename for sublist in args.releases for filename in sublist]
     used_versions = load_all_releases(release_files)
     unused_versions = find_unused_versions(used_versions, repository)
+    check_missing_versions(used_versions, repository)
 
     if args.check:
         if not unused_versions:

tests/data/test_repository.yml

@@ -8,6 +8,9 @@ lib1:
   1.2.3:
     source: pypi
     make: pip
+  1.2.4:
+    source: pypi
+    make: pip
   0.1.2:
     source: pypi
     make: pip

tests/data/test_repository_missing.yml

@@ -0,0 +1,4 @@
+lib1:
+  1.2.4+builtin:
+    source: pypi
+    make: sh

tests/test_release_cleanup.py

@@ -5,6 +5,7 @@
 
 from komodo.prettier import prettier
 from komodo.release_cleanup import (
+    check_missing_versions,
     find_unused_versions,
     load_all_releases,
     main,
@@ -83,6 +84,21 @@ def test_unused_versions():
     assert "1.2.3" in unused_versions["lib5"]
 
 
+def test_missing_versions():
+    files = [
+        os.path.join(_get_test_root(), "data/test_releases/2020.01.a1-py27.yml"),
+        os.path.join(_get_test_root(), "data/test_releases/2020.01.a1-py36.yml"),
+        os.path.join(_get_test_root(), "data/test_releases/2020.01.a1-py38.yml"),
+    ]
+    used_versions = load_all_releases(files)
+
+    repository = _load_yaml(
+        os.path.join(_get_test_root(), "data/test_repository_missing.yml")
+    )
+    with pytest.raises(ValueError, match="Missing used version"):
+        check_missing_versions(used_versions, repository)
+
+
 def test_remove_unused_versions():
     files = [
         os.path.join(_get_test_root(), "data/test_releases/2020.01.a1-py27.yml"),