This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Take timestep 0 into account #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
2 tasks
|
Small PR - large impact! Since this is a potentially important change; can we have a commit message which more clearly communicates the potential impact and importance - e.g.: |
joakim-hove
approved these changes
Nov 13, 2018
Start scan at report_step == 0 when looking for active observations. We used to start this scan at 1, and this might have consequences for people with time maps that do not correspond with the observed/simulated data that they provide.
markusdregi
force-pushed
the
use_timestep_0
branch
from
f18e092
to
eebb3e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Previously timestep 0 has not been taken into account when loading observed data.