This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Raise userwarning if workflows can't be run #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
lars-petter-hauge
changed the title
|
Need to do some more checking before this is merged; e.g. if a workflow raises error in between iterations, do we want complete stop? Believe so, but not completely sure. |
|
So, new suggestion for the implementation -> write to |
lars-petter-hauge
force-pushed
the
raise_warning_invalid_workflow
branch
from
af3101e
to
96cdbff
Compare
Merged
lars-petter-hauge
force-pushed
the
raise_warning_invalid_workflow
branch
from
96cdbff
to
dbe4671
Compare
|
So now I think this is in the proper place. I moved it from Also if one wants to use |
lars-petter-hauge
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If a workflow configuration was invalid, libres would not raise any warning.
This does not completely solve issue: equinor/ert#194, but it improves.
Handling issue 194 involves a bit more, e.g. if the config file is to include a stdout/stderror like the forward models, then parsing the file must be updated. It remains to find out if that is worth doing in c (as it is now), or if we should implement parsing yml config in python while retaining the old parsing for backwards compatibility.