Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twoport #322

Merged
merged 146 commits into from
Jun 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
146 commits
Select commit Hold shift + click to select a range
3fa6063
refact: commented out dead code
fannemel Jan 7, 2022
b98e474
Merge remote-tracking branch 'upstream/master'
fannemel Jan 13, 2022
2f0a908
wip
fannemel Jan 13, 2022
159db5b
Merge remote-tracking branch 'upstream/master' into twoport
fannemel Jan 13, 2022
16941c2
Merge branch 'master' into twoport
fannemel Jan 18, 2022
bf448fe
Merge branch 'master' into twoport
fannemel Jan 19, 2022
a47c872
Merge branch 'master' into twoport
fannemel Jan 25, 2022
9c8f116
Merge branch 'master' into twoport
asmfstatoil Feb 4, 2022
eab54fa
wip
asmfstatoil Feb 7, 2022
dba0717
wip
asmfstatoil Feb 7, 2022
ada9e9f
Merge branch 'master' into twoport
asmfstatoil Feb 8, 2022
ab81f4c
Merge branch 'master' into twoport
asmfstatoil Feb 9, 2022
0063d1e
Merge branch 'master' into twoport
asmfstatoil Feb 10, 2022
403b863
Merge branch 'master' into twoport
asmfstatoil Feb 10, 2022
d8c380e
Merge branch 'master' into twoport
asmfstatoil Feb 11, 2022
b12a667
Merge branch 'master' into twoport
asmfstatoil Feb 15, 2022
7ee493e
Merge branch 'master' into twoport
asmfstatoil Feb 15, 2022
fb398ff
Merge branch 'master' into twoport
asmfstatoil Feb 16, 2022
13046f8
wip
asmfstatoil Feb 16, 2022
2aa5b7c
Create ProcessSystemRunTransientTest.java
EvenSol Feb 17, 2022
2d1ac53
first draft
asmfstatoil Feb 17, 2022
b3aa74e
Merge branch 'master' into sim_class
asmfstatoil Feb 17, 2022
7f9ef86
testfix, not namedclass not serializable
asmfstatoil Feb 17, 2022
e2cd86c
Merge remote-tracking branch 'upstream/testRunTransient' into sim_class
asmfstatoil Feb 17, 2022
b63c769
fix
asmfstatoil Feb 17, 2022
bbba8f5
Merge branch 'sim_class' into twoport
asmfstatoil Feb 17, 2022
2349006
cleanup
asmfstatoil Feb 17, 2022
1e3e812
revert
asmfstatoil Feb 17, 2022
98bc643
revert
asmfstatoil Feb 17, 2022
99e1418
b
asmfstatoil Feb 17, 2022
d4aafa9
Merge branch 'sim_class' into twoport
asmfstatoil Feb 17, 2022
0540d85
Merge branch 'master' into twoport
asmfstatoil Feb 19, 2022
aa6cc80
revert
asmfstatoil Feb 19, 2022
2dc7ae5
commit
asmfstatoil Feb 19, 2022
d81c489
revert#
asmfstatoil Feb 19, 2022
40f16fb
revert
asmfstatoil Feb 19, 2022
f673f7d
docfix
asmfstatoil Feb 19, 2022
b25bde2
docfix
asmfstatoil Feb 19, 2022
5325e21
docfix
asmfstatoil Feb 19, 2022
5c894e3
bugfix
asmfstatoil Feb 19, 2022
588d0e2
require name
asmfstatoil Feb 19, 2022
a2dbb31
wip
asmfstatoil Feb 19, 2022
c921d5d
wip
asmfstatoil Feb 19, 2022
cf8a3e6
Merge branch 'master' into twoport
asmfstatoil Feb 21, 2022
a894919
Merge branch 'master' into twoport
asmfstatoil Feb 21, 2022
39fe602
Merge branch 'master' into twoport
asmfstatoil Feb 21, 2022
19f3926
prefer constructors that set name
asmfstatoil Feb 22, 2022
1848820
refact: ensure name is set by ctor
asmfstatoil Feb 22, 2022
00c285b
fixed tests
asmfstatoil Feb 22, 2022
c381f8c
marked redundant constructors without name as deprecated
asmfstatoil Feb 22, 2022
1b58201
Merge branch 'pragmatic_naming' into twoport
asmfstatoil Feb 22, 2022
39a9c8f
bugfix
asmfstatoil Feb 23, 2022
7cf91be
wip
asmfstatoil Feb 23, 2022
f0f5eeb
Merge branch 'master' into twoport
asmfstatoil Feb 23, 2022
64df9fa
revert
asmfstatoil Feb 23, 2022
8bd77ec
revert
asmfstatoil Feb 23, 2022
d420646
revert
asmfstatoil Feb 23, 2022
55b8400
wip
asmfstatoil Feb 23, 2022
0233d3f
wip
asmfstatoil Feb 23, 2022
e881943
wip
asmfstatoil Feb 23, 2022
dcadcff
revert
asmfstatoil Feb 23, 2022
4b030ae
first draft
asmfstatoil Feb 24, 2022
d8535c3
Merge branch 'master' into ctor_names
asmfstatoil Feb 24, 2022
0b96f7e
docfix
asmfstatoil Feb 24, 2022
f31e43c
docfix
asmfstatoil Feb 24, 2022
cf2c6d4
fixes
asmfstatoil Feb 24, 2022
1681858
more
asmfstatoil Feb 24, 2022
80696db
more
asmfstatoil Feb 24, 2022
bd860de
more
asmfstatoil Feb 24, 2022
1d8020a
style
asmfstatoil Feb 25, 2022
4efd1a3
Merge branch 'master' into twoport
asmfstatoil Feb 28, 2022
01a4eea
chore: update actions
asmfstatoil Feb 28, 2022
bea289f
Merge remote-tracking branch 'upstream/master'
asmfstatoil Feb 28, 2022
f75f26f
Merge branch 'master' into twoport
asmfstatoil Feb 28, 2022
a2dcb88
Merge branch 'master' into ctor_names
asmfstatoil Feb 28, 2022
59784a4
Merge branch 'ctor_names' into twoport
asmfstatoil Feb 28, 2022
2110937
bugfix: merge error
asmfstatoil Feb 28, 2022
c7f3e36
bugfix: merge error
asmfstatoil Feb 28, 2022
eaa3084
Merge branch 'ctor_names' into twoport
asmfstatoil Feb 28, 2022
1211b1b
bugfix: merge error
asmfstatoil Feb 28, 2022
9b30b94
Merge remote-tracking branch 'upstream/master' into twoport
asmfstatoil Feb 28, 2022
2c67e9b
Merge remote-tracking branch 'upstream/master'
asmfstatoil Feb 28, 2022
0228508
Merge remote-tracking branch 'upstream/master'
asmfstatoil Feb 28, 2022
40c3cbc
Merge branch 'master' into twoport
asmfstatoil Feb 28, 2022
cf56e30
revert
asmfstatoil Feb 28, 2022
d653797
revert
asmfstatoil Feb 28, 2022
702f973
docfix: deprecated
asmfstatoil Feb 28, 2022
558023e
bugfix: mergeerror
asmfstatoil Feb 28, 2022
0d75441
deprecations
asmfstatoil Feb 28, 2022
512558b
redundant interface
asmfstatoil Feb 28, 2022
0c65273
rm
asmfstatoil Feb 28, 2022
6e810f1
Merge branch 'master' into twoport
asmfstatoil Feb 28, 2022
1ac26b0
Merge branch 'master' into twoport
asmfstatoil Feb 28, 2022
bb40629
stuff
asmfstatoil Mar 1, 2022
b130c2d
wip
asmfstatoil Mar 1, 2022
c8623df
wip
asmfstatoil Mar 1, 2022
268b919
Merge branch 'master' into twoport
asmfstatoil Mar 3, 2022
992390d
Merge branch 'master' into twoport
asmfstatoil Mar 6, 2022
31e1562
Merge branch 'master' into twoport
asmfstatoil Mar 7, 2022
8079bd4
Merge branch 'master' into twoport
asmfstatoil Mar 9, 2022
fdbe877
Merge branch 'master' into twoport
asmfstatoil Mar 9, 2022
7770d22
chore: release version 2.3.2
asmfstatoil Mar 9, 2022
3f80720
Merge remote-tracking branch 'upstream/master'
asmfstatoil Mar 10, 2022
4b31f2e
Merge branch 'master' into twoport
asmfstatoil Mar 10, 2022
a019cca
Merge remote-tracking branch 'upstream/master'
asmfstatoil Mar 15, 2022
f156af2
Merge remote-tracking branch 'upstream/master'
asmfstatoil Mar 15, 2022
7d2192f
Merge branch 'master' into twoport
asmfstatoil Mar 15, 2022
4e74b00
Merge remote-tracking branch 'upstream/master'
asmfstatoil Mar 15, 2022
0e38847
Merge branch 'master' into twoport
asmfstatoil Mar 15, 2022
39fb99f
Merge remote-tracking branch 'upstream/master' into twoport
asmfstatoil Mar 16, 2022
d0e328d
Merge branch 'master' into twoport
asmfstatoil Mar 16, 2022
24e9202
fix
asmfstatoil Mar 17, 2022
ce6db3e
Merge branch 'master' into twoport
asmfstatoil Mar 26, 2022
168910a
Merge branch 'master' into twoport
asmfstatoil Apr 12, 2022
b076cbc
autoformat
asmfstatoil May 30, 2022
8298596
Merge branch 'master' into twoport
asmfstatoil May 30, 2022
c9625ec
stuff
asmfstatoil May 30, 2022
90aeb97
stuff
asmfstatoil May 30, 2022
8969736
revert
asmfstatoil May 30, 2022
0f8bbfb
Merge branch 'master' into twoport
asmfstatoil May 31, 2022
6adff80
stuff2
asmfstatoil May 31, 2022
ecdc6fc
docfix
asmfstatoil May 31, 2022
48b9a1b
Merge branch 'master' into twoport
asmfstatoil May 31, 2022
2d35959
revert
asmfstatoil May 31, 2022
cf503a1
Merge branch 'master' into twoport
asmfstatoil Jun 1, 2022
ff51f0b
revert
asmfstatoil Jun 1, 2022
72b422b
revert
asmfstatoil Jun 1, 2022
bd2fc3a
revert
asmfstatoil Jun 1, 2022
8d47ef6
Merge branch 'master' into twoport
asmfstatoil Jun 2, 2022
e16cec8
Merge branch 'master' into twoport
asmfstatoil Jun 3, 2022
a37930d
Merge branch 'master' into twoport
asmfstatoil Jun 3, 2022
14d7130
Merge branch 'master' into twoport
asmfstatoil Jun 4, 2022
e446540
revert
asmfstatoil Jun 4, 2022
880a831
revert
asmfstatoil Jun 4, 2022
59b7da3
Merge branch 'master' into twoport
asmfstatoil Jun 4, 2022
4068b69
Merge branch 'master' into twoport
asmfstatoil Jun 4, 2022
0f855cc
revert
asmfstatoil Jun 4, 2022
a18591d
Merge branch 'master' into twoport
asmfstatoil Jun 5, 2022
2472d6e
revert
asmfstatoil Jun 5, 2022
52e4c89
revert
asmfstatoil Jun 5, 2022
e83adb7
revert
asmfstatoil Jun 5, 2022
54a0143
Merge branch 'master' into twoport
asmfstatoil Jun 5, 2022
bbe4a17
revert
asmfstatoil Jun 5, 2022
e3738c3
revert
asmfstatoil Jun 5, 2022
3941437
revert
asmfstatoil Jun 5, 2022
9e35805
revert
asmfstatoil Jun 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import neqsim.fluidMechanics.flowNode.twoPhaseNode.twoPhasePipeFlowNode.DropletFlowNode;
import neqsim.fluidMechanics.flowNode.twoPhaseNode.twoPhasePipeFlowNode.StratifiedFlowNode;
import neqsim.fluidMechanics.geometryDefinitions.pipe.PipeData;
import neqsim.processSimulation.processEquipment.ProcessEquipmentBaseClass;
import neqsim.processSimulation.processEquipment.TwoPortEquipment;
import neqsim.processSimulation.processEquipment.stream.Stream;
import neqsim.processSimulation.processEquipment.stream.StreamInterface;
import neqsim.thermo.system.SystemInterface;
Expand All @@ -18,11 +18,9 @@
* @author esol
* @version $Id: $Id
*/
public class NeqSimUnit extends ProcessEquipmentBaseClass {
public class NeqSimUnit extends TwoPortEquipment {
private static final long serialVersionUID = 1000;

StreamInterface inletStream;
StreamInterface outStream;
SystemInterface thermoSystem;
private String equipment = "pipeline";
String flowPattern = "stratified";
Expand Down Expand Up @@ -56,27 +54,16 @@ public NeqSimUnit(StreamInterface inletStream, String equipment, String flowPatt
* @param inletStream a {@link neqsim.processSimulation.processEquipment.stream.Stream} object
*/
public void setInletStream(StreamInterface inletStream) {
this.inletStream = inletStream;
this.inStream = inletStream;

thermoSystem = inletStream.getThermoSystem().clone();
outStream = new Stream("outStream", thermoSystem);
}

/**
* <p>
* Getter for the field <code>outStream</code>.
* </p>
*
* @return a {@link neqsim.processSimulation.processEquipment.stream.Stream} object
*/
public StreamInterface getOutStream() {
return outStream;
}

/** {@inheritDoc} */
@Override
public void run() {
thermoSystem = inletStream.getThermoSystem().clone();
thermoSystem = inStream.getThermoSystem().clone();
if (equipment.equals("pipeline") && flowPattern.equals("stratified")) {
runStratified();
} else if (equipment.equals("pipeline") && flowPattern.equals("annular")) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public double calcMixStreamEnthalpy() {
}

/** {@inheritDoc} */
@Override
@Deprecated
public StreamInterface getOutStream() {
return mixedStream;
}
Expand Down