Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: simplify EOS subclass constructor #953

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 34.68%. Comparing base (720ebe4) to head (23342e9).

❗ Current head 23342e9 differs from pull request most recent head fe02768. Consider uploading reports for the commit fe02768 to get more accurate results

Files Patch % Lines
.../main/java/neqsim/thermo/system/SystemBWRSEos.java 0.00% 1 Missing ⚠️
...java/neqsim/thermo/system/SystemDesmukhMather.java 0.00% 1 Missing ⚠️
.../main/java/neqsim/thermo/system/SystemDuanSun.java 0.00% 1 Missing ⚠️
...n/java/neqsim/thermo/system/SystemGERG2004Eos.java 0.00% 1 Missing ⚠️
...main/java/neqsim/thermo/system/SystemGEWilson.java 0.00% 1 Missing ⚠️
...java/neqsim/thermo/system/SystemKentEisenberg.java 0.00% 1 Missing ⚠️
src/main/java/neqsim/thermo/system/SystemNRTL.java 0.00% 1 Missing ⚠️
...ain/java/neqsim/thermo/system/SystemPrEos1978.java 0.00% 1 Missing ⚠️
...rc/main/java/neqsim/thermo/system/SystemRKEos.java 0.00% 1 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemTSTEos.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #953   +/-   ##
=========================================
  Coverage     34.68%   34.68%           
+ Complexity     5275     5274    -1     
=========================================
  Files           700      700           
  Lines         69613    69601   -12     
  Branches       7984     7984           
=========================================
- Hits          24143    24139    -4     
+ Misses        43988    43980    -8     
  Partials       1482     1482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update!

@asmfstatoil asmfstatoil merged commit b46223f into equinor:master Mar 15, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the refact_system_ctor branch March 15, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants