Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests working again #449

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Get tests working again #449

merged 1 commit into from
Jun 6, 2023

Conversation

kwinkunks
Copy link
Member

No description provided.

@kwinkunks kwinkunks requested review from berland and xjules June 5, 2023 13:04
@kwinkunks kwinkunks changed the title Add missing Optionals Get tests working again Jun 5, 2023
@berland
Copy link
Collaborator

berland commented Jun 5, 2023

@lindjoha ?

@codecov-commenter
Copy link

Codecov Report

Merging #449 (dd8458a) into master (d431cc6) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head dd8458a differs from pull request most recent head b37317e. Consider uploading reports for the commit b37317e to get more accurate results

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   95.08%   95.17%   +0.08%     
==========================================
  Files          31       31              
  Lines        4374     4413      +39     
==========================================
+ Hits         4159     4200      +41     
+ Misses        215      213       -2     
Impacted Files Coverage Δ
ecl2df/pillars.py 100.00% <ø> (ø)
ecl2df/summary.py 96.82% <ø> (ø)
ecl2df/__init__.py 94.73% <100.00%> (+5.26%) ⬆️
ecl2df/common.py 99.71% <100.00%> (+0.05%) ⬆️
ecl2df/equil.py 100.00% <100.00%> (ø)
ecl2df/grid.py 97.87% <100.00%> (ø)
ecl2df/trans.py 97.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwinkunks kwinkunks mentioned this pull request Jun 5, 2023
@lindjoha lindjoha self-requested a review June 6, 2023 05:56
Copy link
Collaborator

@lindjoha lindjoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwinkunks kwinkunks merged commit aeb0953 into master Jun 6, 2023
4 checks passed
@sondreso sondreso deleted the fix-typing-issues branch June 7, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants