Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests working again #449

Merged
merged 1 commit into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ecl2df/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -627,8 +627,8 @@ def df2ecl(
def generic_ecltable(
dframe: pd.DataFrame,
keyword: str,
comment: str = None,
renamer: Dict[str, str] = None,
comment: Optional[str] = None,
renamer: Optional[Dict[str, str]] = None,
drop_trailing_columns: bool = True,
) -> str:
"""Construct a typical Eclipse table for data following
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
REQUIREMENTS = [
"ecl",
"numpy",
"opm>=2020.10.2", # NB: Pypi versions.
"pandas",
"opm>=2020.10.2,<=2022.4", # NB: Pypi versions.
"pandas<2.0",
"pyarrow",
"pyyaml>=5.1",
"treelib",
Expand Down