Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment in generated app regarding sys.executable #311

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Add comment in generated app regarding sys.executable #311

merged 1 commit into from
Sep 22, 2020

Conversation

anders-kiaer
Copy link
Collaborator

@anders-kiaer anders-kiaer commented Sep 22, 2020 •
edited
Loading

Contributor checklist

  • 🎉 This PR closes komodo version webviz-config-equinor#37.
  • 📜 I have broken down my PR into the following tasks:
    • Add sys.executable to jinja2template.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@anders-kiaer anders-kiaer marked this pull request as ready for review September 22, 2020 18:56
@anders-kiaer anders-kiaer self-assigned this Sep 22, 2020
@anders-kiaer anders-kiaer mentioned this pull request Sep 22, 2020
Closed
@asnyv
Copy link
Collaborator

asnyv commented Sep 22, 2020

LGTM 🎠

@anders-kiaer anders-kiaer merged commit cda8e8e into equinor:master Sep 22, 2020
@anders-kiaer anders-kiaer deleted the storesysexecutable branch September 22, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnyv asnyv Awaiting requested review from asnyv

@HansKallekleiv HansKallekleiv Awaiting requested review from HansKallekleiv

Assignees

@anders-kiaer anders-kiaer

Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anders-kiaer @asnyv