Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webviz-ert: adjust timeout #428

Closed
xjules opened this issue Apr 7, 2023 · 1 comment
Closed

webviz-ert: adjust timeout #428

xjules opened this issue Apr 7, 2023 · 1 comment
Assignees

Comments

@xjules
Copy link
Contributor

xjules commented Apr 7, 2023

We do have another flaky test, which fails when testing in Azure:

FAILED tests/views/test_parameter_selector.py::test_search_input_return_functionality - selenium.common.exceptions.TimeoutException: Message: text -> default not found inside element within 4s
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
@kwinkunks kwinkunks mentioned this issue Apr 14, 2023
1 task
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
kwinkunks added a commit to kwinkunks/webviz-ert that referenced this issue Apr 14, 2023
We are experiencing flaky test timeouts when running tests on Azure.
We have been addressing this by increasing timeouts in affected calls
but this seems unsustainable. This commit instead allows us to change
the implicit and explicit waits (see Selenium and dash.testing docs)
for all tests. Connected to equinor#428.

It also adds optional arguments to pytest to change these timeouts at
runtime, and allows testkomodo.sh to detect the environment (azure vs
onprem) from an environment variable.

It also removes a hacky `wait_a_bit` function, replacing it in one
case with an undocumented wait_for_no_elements call from dash.testing.
@xjules
Copy link
Contributor Author

xjules commented May 15, 2023

Closing this one as being part of #426

@xjules xjules closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants