Simplify dash timeout #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwinkunks
added
the
improvement
|
Can one of the admins verify this patch? |
kwinkunks
force-pushed
the
simplify-dash-timeout
branch
from
9b760cd
to
1942a27
Compare
kwinkunks
force-pushed
the
simplify-dash-timeout
branch
from
1164374
to
1bafc72
Compare
|
Three tests timed out, so will increase the timeout in the workflow and see if that fixes it. Also Selenium seems to be throwing a lot of warnings, non-fatal. |
kwinkunks
force-pushed
the
simplify-dash-timeout
branch
2 times, most recently
from
3b24cf9
to
16ffdaa
Compare
We are experiencing flaky test timeouts when running tests on Azure. We have been addressing this by increasing timeouts in affected calls but this seems unsustainable. This commit instead allows us to change the implicit and explicit waits (see Selenium and dash.testing docs) for all tests. Connected to equinor#428. It also adds optional arguments to pytest to change these timeouts at runtime, and allows testkomodo.sh to detect the environment (azure vs onprem) from an environment variable. It also removes a hacky `wait_a_bit` function, replacing it in one case with an undocumented wait_for_no_elements call from dash.testing.
kwinkunks
force-pushed
the
simplify-dash-timeout
branch
from
16ffdaa
to
703e8a0
Compare
|
Doubled both timeouts (implicit and explicit) and two tests are failing. I don't tihnk the yare flaky / performance related, and they failed on the last PR before this one too, but I can't see what the issue is right now. I cannot reproduce it locally. |
|
As tests are failing, I would think it is not ready for review. I will move to todo, sorry if it was a mistake from my side. |
|
Closing this because we are no longer experiencing these flakinesses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Timeouts were set in a few different places, and we're trying to change them and add others to cope with Azure performance... but it's getting out of hand. Does not resolve but is connected to the perma-issue #428.
Approach
conftest.pytestkomodo.shscript detects the$CI_RUNNER_LABELenv var has the valueazurewait_a_bitfunction which added custom sleepsPre review checklist