Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements to makeFullMesh function in MapLayer #1662

Closed
8 tasks
rubenthoms opened this issue Sep 21, 2023 · 1 comment · Fixed by #1689
Closed
8 tasks

Performance improvements to makeFullMesh function in MapLayer #1662

rubenthoms opened this issue Sep 21, 2023 · 1 comment · Fixed by #1689
Assignees
@nilscb
Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Sep 21, 2023 •
edited by nilscb
Loading

Low hanging improvements:

Additional potential improvements:

  • Reuse triangle vertices for lines
  • Constant z in flat maps
  • WebWorker still required?
  • Normals as signed byte
@rubenthoms rubenthoms added the enhancement New feature or request label Sep 21, 2023
@HansKallekleiv
Copy link
Collaborator

Related #1665

nilscb added a commit to nilscb/webviz-subsurface-components that referenced this issue Oct 10, 2023
@nilscb
performance: Performance improvements to makeFullMesh function in Map…
54af473 
…Layer equinor#1662
@nilscb nilscb linked a pull request Oct 10, 2023 that will close this issue
perf: Performance improvements to makeFullMesh function in MapLayer #1662 #1689
Merged
nilscb added a commit that referenced this issue Oct 12, 2023
@nilscb
perf: Performance improvements to makeFullMesh function in MapLayer #…
f7a79cd 
…1662 (#1689)

* In progress

* In progress

* In prcess of  using typed arrays in web worker

* Got it working with trianlges. Next is lines.

* Lines working.. next optimize lines by using indeces instead..

* Lines by indices works..next is constant over a cell

* Constant over a cell works (and lines).. next transferable objects

* Dont draw inactice cell. Modified cellCenteredPropertiesLayer story with one undefined cell

* Removed MeshType etc and send all attributes as typed arrays. Next.. send them transerable..

* Tranferable objects as return values from webworker works..next make webworker optional..

* Removed webworker.

* Send normals as signed 8 bit to save memory.

* In progress

* Lint & typecheck

* smal fix

* performance: Performance improvements to makeFullMesh function in MapLayer  #1662

* Code comment fixes.

* Code comment fixes.
 - use camelcase for names. Added comments to functions to explain behaviior.

* Lint fix.

* Code comment fix. Changed deprecated ComponentStory to StoryFn

* Storybook complained about this one.
hkfb pushed a commit that referenced this issue Oct 12, 2023
@semantic-release-bot
chore(release): 0.3.1 [skip ci]
c250869 
## [0.3.1](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.3.0...subsurface-viewer@0.3.1) (2023-10-12)

### Performance Improvements

* Performance improvements to makeFullMesh function in MapLayer  [#1662](#1662) ([#1689](#1689)) ([f7a79cd](f7a79cd))
@nilscb nilscb added AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilscb nilscb

Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.
Projects
None yet
Milestone
No milestone
3 participants
@nilscb @HansKallekleiv @rubenthoms