-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Performance improvements to makeFullMesh function in MapLayer #1662 #1689
Conversation
…ith one undefined cell
…send them transerable..
…webworker optional..
I saw that you did some perf measures and that you removed the webworker. |
BTW, add a description to summarize the optimizations you apply in this PR |
In the story "BigMap" in webiz which is a map with 1452x1141 nodes the loading time went down from approximately 0.75 sec to 0.2 sec, I will investigate a bit the memory usage. |
I added a description of what has been done above. |
typescript/packages/subsurface-viewer/src/layers/map/mapLayer.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/privateMapLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/mapLayer.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/fragment.fs.glsl.ts
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/fragment_lines.glsl.ts
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/mapLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/mapLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/map/mapLayer.ts
Outdated
Show resolved
Hide resolved
- use camelcase for names. Added comments to functions to explain behaviior.
return <SubsurfaceViewer {...subsurfaceViewerArgs} />; | ||
}; | ||
|
||
export const TypedArrayInput: ComponentStory<typeof SubsurfaceViewer> = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ComponentStory
is deprecated in Storybook > v6.
You can resolve and merge if you like, but I think we should use the new format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I changed it to "StoryFn"
🎉 This PR is included in version 0.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Optimizations done: